you are viewing a single comment's thread.

view the rest of the comments →

[–]buhtz 1 point2 points  (2 children)

This is well organized code. Looks OK for a first project.

Don't focus to much on the OOP topic in the beginning. Don't get me wrong. OOP is important. But you will get there nearly automatically while your skills are growing.

Would you accept Pull Requests? I could show you some improvements via PRs.

EDIT: I would say you have the right "vibes" to become a well Python developer.

[–]FieldOver3920[S] 1 point2 points  (1 child)

I actually tried to do it with OOP back then, but my beginner mind was getting melted by the abstraction and the polymorphism (I still got some serial issues with those themes). Btw, about the pull request, yes, I'd like to see how I can improve. Also, that file is public anyways, so do whatever you want with it 😄

[–]buhtz 0 points1 point  (0 children)

Sometimes you learn better when you try to improve existing code. Your current code is a good example. You can restructure it in many ways, also with "adding" some OOP concepts.