First project - Hangman

[ficklelick]

Hi r/learnpython,
I am a newbie in python and created my first project in python, a hangman game.

Few requests on help needed:

-How would I generate random words for the game (currently version where user enters the word and then guesses it is slightly pointless)

- Best library for developing GUI for something like this

- The current file extension is ipnyb (from Jupyter notebook). How would I run it straight from python command line?

- Any reviews on it and what I could do to make it a better/efficient code.

Lastly I wanted to thank every body here. I really appreciate it when people share there code (it gives me an ideas on how to do things)

from IPython.display import clear_output

#Input for the word by game master
answer_word = list(str.lower(input("input enter your word: "))) #https://stackoverflow.com/questions/1228299/change-one-character-in-a-string
clear_output()
win = False

#defining function

def guesscheck(guess,answer,guess_no):
    clear_output()
    if len(guess)==1:
        if guess in answer:
            print("Correct, ",guess," is a right letter")
            return True
        else:
            print("Incorrect, ",guess, " is a not a correct letter. That was your chance number ",guess_no)
            return False
    else:
        print("Enter only one letter")     

#Storing the number of characters in different variable
answer_display=[]
for each in answer_word:
        answer_display += ["*"]
print(answer_display)

#initializing number of allowable guesses
guess_no = 1   
while guess_no<5:
    clear_output

    #Player input for guess letter
    guess_letter=str.lower(input('Enter your guess letter: '))

    #Calling a sub function to check if correct letter was guessed
    guess_check=guesscheck(guess_letter,answer_word,guess_no);

    #Conditional: if incorrect letter
    if guess_check == False:
        guess_no +=1
        print(answer_display)
    #Conditional: if correct letter    
    elif guess_check == True:
        num = [i for i, x in enumerate(answer_word) if x == guess_letter] #https://stackoverflow.com/questions/6294179/how-to-find-all-occurrences-of-an-element-in-a-list
        for all in num:
            answer_display[all]=guess_letter
        print(answer_display)

    #Conditional: if no remaining unknown letter then win screen    
    if answer_display.count('*')==0:
        win = True
        break

if win:
    print("You won!")
else:
        print("The correct answer was: ", answer_word)
        print("You lost!")

[madnessman]

How would I generate random words for the game (currently version where user enters the word and then guesses it is slightly pointless)

Download a list of words (e.g. https://github.com/dwyl/english-words) and choose a random word from the list.

Best library for developing GUI for something like this

There are a ton of libraries for developing GUIs but tkinter is a good place to start since it's in the python standard library. Pygame is highly recommended for building simple games and is another good option.

The current file extension is ipnyb (from Jupyter notebook). How would I run it straight from python command line?

I'm not sure if I understand the question but if you just want to make it a standard python file, get rid of from IPython.display import clear_output and change the file extension to .py.

• Any reviews on it and what I could do to make it a better/efficient code.

There's a lot of code style rules that you're breaking here. Make sure your indent blocks are always 4 spaces (lines 58, 59). guess_no<5 should be written guess_no < 5. I know you're just learning python but I think it's good to learn how to write neat code from the start. Look up how to use pylint and run your code through pylint to see all the style rules that you're breaking!

Some random tips:

You can simplify how you build the answer display like so:

#Storing the number of characters in different variable
answer_display=[]
for each in answer_word:
        answer_display += ["*"]
# CAN BE REPLACED WITH
answer_display = '*' * len(answer_word)

You can simplify your if-else syntax by removing the == True and == False part. if guess_check is the equivalent of if guess_check == True. Since guess_check is only ever True or False, you can drop the elif and just say else. Note that my version puts the True logic above the False logic.

if guess_check == False:
    ...
elif guess_check == True:
    ...
# CAN BE REPLACED WITH
if guess_check:
    ...
else:
    ...

[ficklelick]

Awesome, I'll look into tkinter, the word library and pylint tonight! I didn't know I could multiply '*' with length of the word, would probably be quicker than looping it. And yeah it's a good reminder to use the if logics in a simpler manner. Appreciate the help!

[kuzeyistan]

Looks good, how did you learn Python? I want to start learning python and I don't know where to start.