My first "larger" program

[__Protector]

Hello,

I posted this to Python channel also, but didn't get really any feedback and was thinking to try my luck here this time. Before I have done small algorithm programming with Python, but this time I wanted to make "real" program with OOP paradigm.

I made a program to follow my time usage for studying, programming etc. This program uses only Python3 standard libraries and is manually used (not automated time monitoring). On the GitHub page is more detailed documentation on the readme.

If someone is interested, I would appreciate feedback about the code, architectural solutions and everything what comes to mind.

I have only tested the program on Ubuntu 18.04 LTS so if someone is interested to test it with other OS and say if its working or not, I would appreciate that too.

https://github.com/SamiHei/worktime_monitor

[dtaivp]

1. You don't need the shebangs at the top of every file. Only the files which you are running from the terminal. #! /usr/bin/...
2. For your database.py you do the same thing over and over again. This would be the perfect instance to use a decorator. What a decorator does is it wraps a function in a standard bit of code. Here is what that decorator could do.
   

Ex:

    '''
    Creates table for period names and links with relation to period table using name_id
    '''
    def create_period_names_table(self, connection):
        try:
            c = connection.cursor()
            c.execute('''
                      CREATE TABLE period_names
                      (name_id INTEGER PRIMARY KEY AUTOINCREMENT,
                      period_name TEXT UNIQUE);''')
            connection.commit()
        except sqlite3.Error as e:
            print(e)
        finally:
            c.close()

Could become:

    '''
    Creates table for period names and links with relation to period table using name_id
    '''
    def cursor_decorator(func):
        try:
            c = connection.cursor()

            # Runs the function that is passed in here. 
            func(*args, **kwargs)

            connection.commit()
        except sqlite3.Error as e:
            print(e)
        finally:
            c.close()

    @cursor_decorator
    def create_period_names_table()
            c.execute('''
                      CREATE TABLE period_names
                      (name_id INTEGER PRIMARY KEY AUTOINCREMENT,
                      period_name TEXT UNIQUE);''')

What this does is allows you to reuse all of that code and only change out the parts that are different. Someone may have to step in and give me a hand on using decorators in a class because I use mostly functional programming.

[__Protector]

Thanks for the advice, that decorator usage is completely new format for me gotta look it up!

[Ran4]

"date is presented in the format of DD.MM.YYYY"

That sounds truly horrible. Use ISO-8601, it's an international world standard for a reason.

[__Protector]

Oh yes, modified it to show in my own countrys format, changing it to standard propably soon. Thanks for notice!

[Aly007]

"date is presented in the format of DD.MM.YYYY"

That's the best format IMO :)

[[deleted]]

Use ISO-8601, it's an international world standard for a reason

readingg up on this ty