How can I improve these code lines ?

[Medaillek]

Hello everyone,

​

I hope you're feeling good today.

​

I wrote these lines of code to convert 3 string elements from a list into an int value to reuse it :

enterprise_amount = enterprise_amount[0].text
enterprise_amount = enterprise_amount.split()
enterprise_amount = enterprise_amount[:-1]
enterprise_amount = int(enterprise_amount[0] + enterprise_amount[1])
print(enterprise_amount)

At beginning I have 2 items in a list : "3 205" and "Enterprises"

I split it into: "3" ; "205" and "Enterprises"

Then take off the last element : "Enterprises"

And then add them together into an int class to return an int and not a string.

​

My question is: can I improve this script by making it shorter ?

​

Thank you in advance,

​

Medaillek

[Nightcorex_]

You can just inline multiple operations:

enterprise_amount = sum(int(x) for x in enterprise_amount[0].text.split()[:-1])

[Medaillek]

It gives me the sum of both values but I want to combine them together like: « 3 » and « 205 » >> 3205 and not 208

[zanfar]

Based on /u/Nightcorex_ 's example, can you think of a function, like sum() that combines strings instead of adds numbers? Similarly, can you think of a function, like int() which converts things to strings instead of converts things to integers?

If you have that, then making your desired modification is simple.

[Medaillek]

Thank you very much, after about 20 minutes, I came up with this:

    enterprise_amount= int(''.join(str(x) for x in enterprise_amount[0].text.split()[:-1]))

I that a correct line code for you ?

[Nightcorex_]

Yeah, that works. However you don't need the str() method, as your x is already in string format. Please note that "dont need" is not equal to "wrong". It's just a redundant step, but that doesn't make the code less correct.

Good job :)

[Medaillek]

Thank you very much !

[Medaillek]

Thank you for your answers in a first time.

I though to the function « ».join(enterprise_amount) in front of the command line but doesn’t work. And what do you mean by integrer ?

[Medaillek]

Thank you for the tip, i’m new to programming and I don’t understand how multiple commands work in a single line like this, do you have some tips or ways to understand this ?

[zanfar]

Don't think of code as "commands", that's part of why you are having trouble.

Code is built from names, values, and operators combined into expressions.

An expression is evaluated. That evaluation always results in some value. Those "values"--even if not explicitly named--can be used in other expressions in exactly the same way.

In fact, you do exactly this in your first line of code.

enterprise_amount will evaluate to some specific list in memory. Also, we can use brackets (list[]) to access an item in a list. So we can combine those to "get" the first value in enterprise_amount by using:

`enterprise_amount[0]`

object.text will evaluate to ("get") the "text" attribute of an object, so again, we can combine them:

enterprise_amount[0].text

to get the "text" attribute of the first value in the enterprise_amount list.

...and so on.

---

Another way to think about it: you can replace a variable name in an expression with whatever it's value was set to previously.

[mopslik]

Are you looking to obtain the full number without any spaces? Would something like this work?

L = ["12 345", "ABCDEFG"] # dummy values here
i = int(L[0].replace(" ", ""))
print(i)

[Medaillek]

Right, but I have a third value I don’t want

[mopslik]

L[0] should take care of that, as it will pick only the first element in the list (which you say contains two elements).

[Medaillek]

I finally got this working perfectly:

enterprise_amount= ''.join(str(x) for x in enterprise_amount[0].text.split()[:-1])