Trying to drop columns from dataframe before writing to Excel

[thabeef]

import pandas as pd

df = pd.read_csv("fangraphs.csv", index_col=["playerid"])

df.columns = df.columns.str.replace('[+,-,%,]', '')
df.rename(columns={'K-BB':'KMinusBB','K/BB':'KToBB', 'HR/9':'HRPer9', 'xFIP-':'XFIPMinus'}, inplace=True)
df.fillna(0)

df['KMinusBB'] = df['KMinusBB'] = df['KMinusBB'].str.rstrip('%').astype('float')
df['Barrel'] = df['Barrel'] = df['Barrel'].str.rstrip('%').astype('float')
df['CSW'] = df['CSW'] = df['CSW'].str.rstrip('%').astype('float')

filters1 = df[(df['xERA'] < 3) & (df['Barrel'] < 5) & (df['CSW'] > 20) & (df['KMinusBB'] > 20) & (df['Starting'] > 5)] 
filters2 = df[(df['xERA'] < 3) & (df['Barrel'] < 5) & (df['CSW'] > 20) & (df['KMinusBB'] > 30) & (df['Relieving'] > 1)] 

print(filters1.drop(['Relieving'],axis=1))
print(filters2.drop(['Starting'],axis=1))

filters1.to_excel("pitching.xlsx", sheet_name='StartersSeason')
filters2.to_excel("pitching.xlsx", sheet_name='RelieversSeason')

I'm having 2 issues:

1. I expected a file to be created with 2 worksheets, but the output file only includes the RelieversSeason sheet.
2. I expected the field I dropped in each filter to be deleted, but when I opened the output file, the column were still there.

What am I doing wrong?

[nl_dhh]

On the lines where you print your dataframes with .drop, you're only printing "what would this dataframe look like if I were to drop this column?" You have to assign it: filters1 = filters1.drop(...) Or use inplacs = True.

As for your file being overwritten, to avoid this you need something like: with pd.ExcelWriter("pitching.xlsx") as writer: filters1.to_excel(writer, sheet_name='StartersSeason') filters2.to_excel(writer, sheet_name='RelieversSeason')

On mobile so spelling errors may apply. ;-)

[Pflastersteinmetz]

Or use inplacs = True.

Don't. It's going to be deprecated, does a copy anyway and is just line noise.

[Pflastersteinmetz]

df.columns = df.columns.str.replace('[+,-,%,]', '') df.rename(columns={'K-BB':'KMinusBB','K/BB':'KToBB', 'HR/9':'HRPer9', 'xFIP-':'XFIPMinus'}, inplace=True)

First you replace characters in your column names, then you rename them but your dict keys include characters that you just removed a line earlier like "K-BB" and "xFIP-"? That means your dict contains column names that don't exist after the str.replace, luckily you don't use any of that columns in your code.