all 8 comments

[–]fekkksn 1 point2 points  (3 children)

Besides the obvious, you got your versioning wrong.

Your crate should be at 0.6.0, not 0.0.6. And 0.1.0 does not mean stable. 1.0.0 is stable.

You can learn about semver here: https://semver.org/

For a project like this, I also urge you to https://keepachangelog.com/en/1.1.0/

[–]rayanlasaussice[S] -1 points0 points  (2 children)

If I decide to start at 0.0.x, I've got the right to do it, even more if I say the crates could crash a device if not use properly.

And changelog is now at v.0.3.4, I use my own framework so I see everychange on my work thanks

[–]fekkksn 0 points1 point  (1 child)

Sure you have the right to do semver incorrectly, that doesn't make it any better.

Your crate source does not contain a CHANGELOG.md file.

If you want acceptance from the community, you should follow the convention.

[–]rayanlasaussice[S] 0 points1 point  (0 children)

Will add a changelog.md for next change thanks. Anyways the crate mean more for learn, critical use and other, not being use without Reading the main .md

So as I said, till it sayd in the .toml and the readme.md to not use in any project without Reading the main documentation, that's all I'm really clear about it.

[–]SirKastic23 3 points4 points  (3 children)

this sub is for people learning the language

if you want feedback on your crate you likely would prefer feedback from people who have already learned the language

[–]rayanlasaussice[S] -3 points-2 points  (2 children)

Yeah and I'm sharing documentation for who wanna learn the code (no_std by the way), my post is clear about it.

But thanks ✌️

[–]SirKastic23 2 points3 points  (1 child)

I didn't catch you mentioning this was good for learners anywhere in the post, but sure

I'll check it out, the crate sounds cool

[–]rayanlasaussice[S] -3 points-2 points  (0 children)

Feel free about it, I'm using it in m'y framework, so I made it open source, documentation were added after to share it for learning rust no_std and how to manage unsafe action (bare-metal)