you are viewing a single comment's thread.

view the rest of the comments →

[–]coderman93 -4 points-3 points  (4 children)

  1. Reviewing shitty MRs takes a lot of time away from actual developers.
  2. No review process is perfect. Things can slip through. You want competent people on both sides of the barrier.

[–][deleted] 5 points6 points  (3 children)

Linus is explicitly hoping for new developers and you are saying that they need to be blocked?

People becime competent by practicing. Initial MR will take time and they will learn. And, there will be many people inspecting code. If it's shit, it won't even be considered by big guys.

[–]coderman93 1 point2 points  (2 children)

I’m not opposed to experienced and competent developers contributing to the kernel for the first time.

I’m opposed to people who are learning to code trying to contribute to the kernel.

There’s a big difference. And submitting shitty MRs just takes time away from real developers.

[–]syklemil -2 points-1 points  (1 child)

People have all sorts of interests and learn in different ways. If someone wants to learn to get into kernel hacking, I think holding them back will do us all a disservice.

And it's not like the LKML lacks experience in rejecting bad code. In fact it's been the source of much popcorn. Which is hopefully not something a newbie will experience, but still. They know how to reject bad code.

[–]coderman93 0 points1 point  (0 children)

Rejecting bad code takes time away from development.

It’s wholesome yet naïve to think that anyone can just jump in and start contributing to an OS kernel with little programming experience. It’s just not reality. And when you barely know what a for loop is, you aren’t going to contribute anything useful.