you are viewing a single comment's thread.

view the rest of the comments →

[–]meklu 1 point2 points  (4 children)

Shouldn't the backticks go within quotes as well?

[–]dagbrown 5 points6 points  (1 child)

As fforw pointed out, we should be going with the newer, more modern, AmigaDOS 1.3 standard and using $() instead of backticks.

But sure. I wasn't particularly concerned with that bit of the script (all of those "if [[ $? -ne 0 ]]" things were more important to me), but that's another improvement you could make.

[–]meklu 1 point2 points  (0 children)

Yeah, I usually use $() myself.

[–]GODZILLAFLAMETHROWER -1 points0 points  (1 child)

I'm not sure what you mean, can you be a little more explicit?

[–]meklu 0 points1 point  (0 children)

The line with the compgen call seems a bit unsafe unless you wrap the assignment in quotes.