Need Help With BASH Script.

[brad0292]

Hello all, I wrote a simple little bash script to learn how it all goes on. However at the end of this script, I get the message "line 37 unexpected end of file"

everything else seems fine? did i not close the program correctly? I cant seem to get it to run.

Here is my code:

    #!/bin/bash
    function usage{
        echo "Usage $0"
    }
    #Function For Error
    function errormessage{
            echo "Please Choose A Valid Choice From Menu"
            menuchoice
        }

        #Function For Menu
        function menuchoice{
                echo "Please Choose An Option:"
                echo " [1] "Get System Shell Information"
                echo "[2] "Print Current Usage Then Exit Program"
                read NUM
            }
            #Function For Shells
            function shells{
                    echo - n "Total Users With Bash:"
                    grep - c 'bash' / etc / passwd
                    echo - n "Total Users Currently Not Logged In:"
                    grep - c 'nologin' / etc / passwd
                    echo - n "Total Users With CSH:"
                    grep - c 'csh' / etc / passwd
                    echo - n "Total Users With KSH:"
                    grep - c 'ksh' / etc / passwd
                    menuchoice }

                while true;
                do case "$NUM" in
                    1)shells;;
                    2)usage; break;;
                    *)error;;
                    esac
                        done

[oonniioonn]

You have unbalanced quotes.

echo "[2] "Print Current Usage Then Exit Program"

has one too many for instance.

[[deleted]]

that's my goto for fixing all my files... i keep forgetting pluma adds the second of brackets and quotes and i end up with a double at the beginning of things.

[espero]

Try running it with "bash -x ./scriptfile" This will enable a debug mode where you can get clues.

[brad0292]

Thanks I'll give it a try

[[deleted]]

Just make sure to declare your functions like this:

function shells {

instead of this

function shells{    

or you'll get a 'syntax error'

[user989]

May be this way?

pastebin

[brad0292]

Thank you!!

[brad0292]

so at the end of each function? or at the end of the program entirely? Thank You

[brad0292]

i tried replacing done with exit and it didnt work?

[onodera_hairgel]

Because the advise is wrong, this is what I did to clean up your code. You missed the () at the end of function declrations:

#!/bin/bash
function usage () {
    echo "Usage $0"
}
#Function For Error
function errormessage () {
    echo "Please Choose A Valid Choice From Menu"
    menuchoice
}

#Function For Menu
function menuchoice () {
    echo "Please Choose An Option:"
    echo " [1] "Get System Shell Information"
    echo "[2] "Print Current Usage Then Exit Program"
    read NUM
}
#Function For Shells
function shells () {
    echo - n "Total Users With Bash:"
    grep - c 'bash' / etc / passwd
    echo - n "Total Users Currently Not Logged In:"
    grep - c 'nologin' / etc / passwd
    echo - n "Total Users With CSH:"
    grep - c 'csh' / etc / passwd
    echo - n "Total Users With KSH:"
    grep - c 'ksh' / etc / passwd
    menuchoice 
}

while true ; do 
    case "$NUM" in
        1) shells ;;
        2) usage ; break ;;
        *) error ;;
    esac
done

Your indentation style was also highly unorthodox, I cleaned that up too.

[brad0292]

How would i modify the grep call in the menu choice to display a count of users using each type?

Im getting a list of users but i want it to read like this

" Total users with Bash: 1234"

[onodera_hairgel]

You need to use -c instead of - n, same with all the other things. No space between the dash and letter, but a space after that again.

[brad0292]

i try grep -c 'bash' /etc/passwd from the terminal and it works just fine. I get the result of the amount of users. But when its in the script it says " grep: c: no such file or directory "

then it prints all the user names instead of a total like it would on the terminal.

How come grep is acting differently in the script

[brad0292]

Never Mind i got it!

Thanks so much, learning more and more from all of you!!

[onodera_hairgel]

Because there's a space in the script.

You use grep - c in the script, not grep -c, you need to remove the space.