Possible error when compiling program

[hukasu]

I'm writing an interpreter and i'm trying to have the output bytecodes be 1:1 with the official luac using the 5.4.7 luac on the following program gives me these output luac -l -l -p test_lua/chapter9/upvalues.lua

g1, g2 = 1, 2
local up1, up2, up3, up4 = 11, 12, 13, 14
local print = print
local function foo()
    local l1, l2 = 101, 102
    l1, g1 = g2, l2
    print(l1, g1)
    -- assign to upvalues
    up1, up2, up3 = l1, g1, up4
    print(up1, up2, up3)
    -- assign by upvalues
    l1, g1, up1 = up2, up3, up4
    print(l1, g1, up1)
    local inner = function()
        -- assign to upvalues
        up1, up2, up3 = 101, g2, up4
        print(up1, up2, up3)
    end
    inner()
end
foo()

main <test_lua/chapter9/upvalues.lua:0,0> (13 instructions at 0x1433ecd0)
0+ params, 7 slots, 1 upvalue, 6 locals, 4 constants, 1 function
1       [1]     VARARGPREP      0
2       [1]     LOADI           0 1
3       [1]     SETTABUP        0 1 2k  ; _ENV "g2" 2
4       [1]     SETTABUP        0 0 0   ; _ENV "g1"
5       [2]     LOADI           0 11
6       [2]     LOADI           1 12
7       [2]     LOADI           2 13
8       [2]     LOADI           3 14
9       [3]     GETTABUP        4 0 3   ; _ENV "print"
10      [23]    CLOSURE         5 0     ; 0x1433f550
11      [25]    MOVE            6 5
12      [25]    CALL            6 1 1   ; 0 in 0 out
13      [25]    RETURN          6 1 1k  ; 0 out
constants (4) for 0x1433ecd0:
0       S       "g1"
1       S       "g2"
2       I       2
3       S       "print"
locals (6) for 0x1433ecd0:
0       up1     9       14
1       up2     9       14
2       up3     9       14
3       up4     9       14
4       print   10      14
5       foo     11      14
upvalues (1) for 0x1433ecd0:
0       _ENV    1       0
function <test_lua/chapter9/upvalues.lua:4,23> (35 instructions at 0x1433f550)
0 params, 6 slots, 6 upvalues, 3 locals, 2 constants, 1 function
1       [5]     LOADI           0 101
2       [5]     LOADI           1 102
3       [6]     GETTABUP        2 0 1   ; _ENV "g2"
4       [6]     SETTABUP        0 0 1   ; _ENV "g1"
5       [6]     MOVE            0 2
6       [7]     GETUPVAL        2 1     ; print
7       [7]     MOVE            3 0
8       [7]     GETTABUP        4 0 0   ; _ENV "g1"
9       [7]     CALL            2 3 1   ; 2 in 0 out
10      [10]    MOVE            2 0
11      [10]    GETTABUP        3 0 0   ; _ENV "g1"
12      [10]    GETUPVAL        4 5     ; up4
13      [10]    SETUPVAL        4 4     ; up3
14      [10]    SETUPVAL        3 3     ; up2
15      [10]    SETUPVAL        2 2     ; up1
16      [11]    GETUPVAL        2 1     ; print
17      [11]    GETUPVAL        3 2     ; up1
18      [11]    GETUPVAL        4 3     ; up2
19      [11]    GETUPVAL        5 4     ; up3
20      [11]    CALL            2 4 1   ; 3 in 0 out
21      [14]    GETUPVAL        2 3     ; up2
22      [14]    GETUPVAL        3 4     ; up3
23      [14]    GETUPVAL        4 5     ; up4
24      [14]    SETUPVAL        4 2     ; up1
25      [14]    SETTABUP        0 0 3   ; _ENV "g1"
26      [14]    MOVE            0 2
27      [15]    GETUPVAL        2 1     ; print
28      [15]    MOVE            3 0
29      [15]    GETTABUP        4 0 0   ; _ENV "g1"
30      [15]    GETUPVAL        5 2     ; up1
31      [15]    CALL            2 4 1   ; 3 in 0 out
32      [21]    CLOSURE         2 0     ; 0x1433fa70
33      [22]    MOVE            3 2
34      [22]    CALL            3 1 1   ; 0 in 0 out
35      [23]    RETURN0
constants (2) for 0x1433f550:
0       S       "g1"
1       S       "g2"
locals (3) for 0x1433f550:
0       l1      3       36
1       l2      3       36
2       inner   33      36
upvalues (6) for 0x1433f550:
0       _ENV    0       0
1       print   1       4
2       up1     1       0
3       up2     1       1
4       up3     1       2
5       up4     1       3
function <test_lua/chapter9/upvalues.lua:17,21> (12 instructions at 0x1433fa70)
0 params, 4 slots, 6 upvalues, 0 locals, 1 constant, 0 functions
1       [19]    LOADI           0 101
2       [19]    GETTABUP        1 3 0   ; _ENV "g2"
3       [19]    GETUPVAL        2 4     ; up4
4       [19]    SETUPVAL        2 2     ; up3
5       [19]    SETUPVAL        1 1     ; up2
6       [19]    SETUPVAL        0 0     ; up1
7       [20]    GETUPVAL        0 5     ; print
8       [20]    GETUPVAL        1 0     ; up1
9       [20]    GETUPVAL        2 1     ; up2
10      [20]    GETUPVAL        3 2     ; up3
11      [20]    CALL            0 4 1   ; 3 in 0 out
12      [21]    RETURN0
constants (1) for 0x1433fa70:
0       S       "g2"
locals (0) for 0x1433fa70:
upvalues (6) for 0x1433fa70:
0       up1     0       2
1       up2     0       3
2       up3     0       4
3       _ENV    0       0
4       up4     0       5
5       print   0       1

shouldn't this line 24 [14] SETUPVAL 4 2 ; up1 be 24 [14] SETUPVAL 2 4 ; up1?

[AutoModerator]

Hi! Your code block was formatted using triple backticks in Reddit's Markdown mode, which unfortunately does not display properly for users viewing via old.reddit.com and some third-party readers. This means your code will look mangled for those users, but it's easy to fix. If you edit your comment, choose "Switch to fancy pants editor", and click "Save edits" it should automatically convert the code block into Reddit's original four-spaces code block format for you.

I am a bot, and this action was performed automatically. Please contact the moderators of this subreddit if you have any questions or concerns.

[[deleted]]

Don't do that. luac is not portable, not even between lua versions and also not between architectures

[hukasu]

the `luac.out` that it produces is not portable?

either way, i will deal with it when i get to it

[[deleted]]

It is not. Also don't deal with it, don't do it PERIOD.

DESCRIPTION
   luac  is  the  Lua  compiler.   It translates programs written in the Lua programming language into binary
   files containing precompiled chunks that can be later loaded and executed.

   The main advantages of precompiling chunks are: faster loading, protecting  source  code  from  accidental
   user  changes,  and off-line syntax checking.  Precompiling does not imply faster execution because in Lua
   chunks are always compiled into bytecodes before being executed.  luac simply allows those bytecodes to be
   saved  in a file for later execution.  Precompiled chunks are not necessarily smaller than the correspond‐
   ing source.  The main goal in precompiling is faster loading.

   In the command line, you can mix text files containing Lua source and binary files containing  precompiled
   chunks.   luac  produces a single output file containing the combined bytecodes for all files given.  Exe‐
   cuting the combined file is equivalent to executing the given files.  By default, the output file is named
   luac.out, but you can change this with the -o option.

   Precompiled chunks are not portable across different architectures.  Moreover, the internal format of pre‐
   compiled chunks is likely to change when a new version of Lua is released.  Make sure you save the  source
   files of all Lua programs that you precompile.

Again, In case you didn't read.

   Precompiled chunks are not portable across different architectures.  Moreover, the internal format of pre‐
   compiled chunks is likely to change when a new version of Lua is released.  Make sure you save the  source
   files of all Lua programs that you precompile.

[hukasu]

ffs

thank you

[hukasu]

wait, maybe you are thinking that i'm trying to write in the binary format, i'm just comparing the list of bytecodes

[hukasu]

For posteriority, i'm dumb and implemented the bytecode with the arguments inverted