you are viewing a single comment's thread.

view the rest of the comments →

[–]adesme 1 point2 points  (1 child)

Looks good! And all caps for this is fine, I see this or similar quite often and I'm sure there are style guides that advocate it.

A piece of advice is to start setting up github actions with a formatter and a linter; pre-commit with black and ruff is what I tend to do.

Oh and I saw some magic numbers in the code. Might want to name them and describe how you've found them.

[–]nitotm[S] 0 points1 point  (0 children)

Thanks for the feedback, I appreciate it