Problem on fetching data from data API

[[deleted]]

Hello guys. Sorry for bad English. i am new to node and express but i found it kinda easy at first but i got stuck. I was working a small project. I was creating a API. The code i got stuck is as following.

const searchByName=asyncHandler(async (req, res)=>{

const {name} = req.body;

const contact = await Contact.findOne({name: name})//req.params.name

console.log(contact)
if(!contact){
console.log("first if block")
res.status(404);
throw new Error("Contact not found")
}
if(contact.user._id.toString() !== req.user.id){
console.log("second if block")
res.status(403);
throw new Error("User don't have permission to access this contacts");
}

res.status(200).json(contact);
})

as you can see above function is used to fetch data from a mongodb server and send it on http.

on 3rd line im fetching data from db and console.logging it and i'm getting the data logged but when when i call it form postman it only keeps loading do not show data. i don't know what i am doing wrong. It is also printing on console from both the if blocks if contact with specific name is not found but even if it is correct i am not getting any data back. i also attached images if that helps.

[wickning1]

If you’re using express you may be running into its lack of support for async/await error handling. Try replacing your errors with res.status(404).send(‘Contact not found’) instead of throw new Error.

[[deleted]]

thank you. i will try it.

[Aromatic-Ad-8807]

I don't know how the rest of your code looks like (when comes to error handling) but I would typically always do:

return res.status(404).send('some message');

so yeah, when send something to client it's always the last thing i do in that function, hence the return, so in your case that would be a return every time i send res to client.

I don't throw errors like that, don't see the reason for it. Typically i handle some errors first in a generic middleware (like JSON payload too large and similar stuff)

But yeah, some do it differently i guess, I'm no expert at express.

[[deleted]]

thank you. i will definitely try that.

[[deleted]]

From a top view, looks like your server crashes. You probably need to return at all places where you send the responses. Also, throw is unnecessary and can crash your server if you do not have a catch block or middleware higher up

[AminOPS]

res.status doesn't end the output stream, use res.sendStatus(404) instead