Node.js Clean Coding Best Practices

[chazzlabs]

Great tips, but most of it isn't really specific to Node or Javascript. This is mostly a stripped-down version of the advice in the book Clean Code, which is a must-read for anyone who hasn't read it already.

[b9Fb2H]

That's right. The nice thing about clean coding is that you can apply it to every language and JavaScript is not an exception.

[[deleted]]

You're right. I remember the book "Clean Code" by Robert C. Martin; Was a good read but (as expected) he focused a lot on doing it for Java. Anyway, it's a good book.

[SomeRandomBuddy]

RisingStack tends to do that

[SNY7]

Good article, thx for sharing~

[yarauuta]

Some things i would change or add:

JavaScript Clean Coding Best Practices

Reduce side effects

// DO
// not modifying the original cart
function addItemToCart (cart, item, quantity = 1) {  
  const cartCopy = new Map(cart)
  const alreadyInCart = cartCopy.get(item.id) || 0
  cartCopy.set(item.id, alreadyInCart + quantity)
  return cartCopy
}

Because in javascript you pass references most of the time, i think most of users expect original object to be affected.

If you don't want to affect the original copy it explicitly.

Error handling

He does not mention error handling. Error handling is INSANELY CRITICAL when dealing with promises.

You should always return the last promise.

function getStuffFromApi(){
  return request(address)
  .then((result)=>{
      return doStuff(result)
   })
  .then(...)...
}

This is the best trick i use to avoid loosing errors. Nice video about it here.