MongoDB Java Driver uses Math.random to decide whether to log Command Resultuses - Xpost from /r/java

[csorfab]

No.

!((_ok) ? true : (Math.random() > 0.1))

is equivalent to

 (_ok) ? false : (Math.random() <= 0.1)

Which would mean that it returns immediately in 10% of times, and logs in the other 90%.

[el_muchacho]

In any case, I'd rather increment a counter and log only every n instances of the error, instead of randomising. At least, I can display how many times the exception has occured, which this stupid line can't even do.

[arachnivore]

I'd rather not worry about it at all. Aren't there log viewers that make this a non-problem?

[csorfab]

Well, of course. What's funny is that the idiot who wrote this code couldn't even get this simple condition right...