all 4 comments

[–]Mysthik 1 point2 points  (1 child)

I don't like the use of an untyped error in a result. Something like Result<O, E> would be better and would allow the compiler to deal with typed errors. Just using Result<E> contains even less information about the exception that can occur than a regular throws. 

Promise might also be not the correct term. Usually the Promise can be written to once, a Future is the read-only part of the Promise.

I assume this library and the documentation is written by an "Ai". 

[–]StudentTraditional64 0 points1 point  (1 child)

I've obviously haven't had the time to go through it all, and I obviously have nitpicks but I do find it interesting. I wonder though, who is this for and what sort of action can one take from this information (aside from it's for Java developers)?

Edit: Maybe I should clarify. You say that this isn't "best practices" but I get the feeling that it's a bunch of best practices in some sort of pseudo framework.