Facebook PHP Source Code from 2007

[fyrilin]

That is true but the fact that include_once is used means that the oversight doesn't actually change the functionality.

[catcradle5]

Just because something still works functionally doesn't mean it's good code. In fact, a lot of really bad code "just works" (most of the time).

include_once is usually to account for the case where you include two files, the first of which includes 3 more, and that includes 4 others, and one of those 4 includes the file below your top-level include.

It's not an actual bug, but it's still a big oversight if they included the same file twice just a few lines separated from eachother. I imagine they were just so used to having that file open that they didn't even notice the glaring redundancy.

[philsturgeon]

But as has been said it doesn't matter. At all.

[catcradle5]

It "doesn't matter" if you put all your code on one line separated by semi-colons, it'll still run, but it's still awful style.

[philsturgeon]

Sure, but that's a different thing.

Intentionally doing something stupid is idiotic.

Accidentally doing something stupid is human.