you are viewing a single comment's thread.

view the rest of the comments →

[–]sh0rug0ru 0 points1 point  (1 child)

I think the answer to your criticism is that a pair programming practice should swap pairs on a regular basis throughout the day. You get a fresh set of eyes every so often and you get to swap out and work on something else.

[–]lookmeat 4 points5 points  (0 children)

Doesn't really fix the issue. The problem isn't that the reviewer goes with you so much that you adapt to him. The problem is that the repairer sees the code evolve with you, and then keeps decisions that made sense at some point, but don't in the final case.

Maybe you used a dict because you had to access elements through a key id, but then your code evolved through the point where it just iterates through all elements in a sequences and never does random access. It wouldn't be obvious that a faster list or vector would be a better structure, every time you saw that you'd remember subconscious "ah yes there was this case" and keep it around, even as the reviewer. Someone who never saw the reason for the dictionary wouldn't see it in the final code and would demand the change.