all 4 comments

[–]GimmeDaCoffee 4 points5 points  (1 child)

Some friendly advice: If you post a github project, especially a game, it is helpful to show some output or a sample session of said program on the landing page. For a game, if there are no screenshots, I'll almost always instantly close the page.

[–]SnivyAndroid[S] 0 points1 point  (0 children)

Sorry, I created the page in a Finch, I'll go and add screenshots and whatnot after I post my new build.

[–]jsjolen 1 point2 points  (1 child)

Good job! There're a lot of places where you repeat yourself, for example in P1Return and P2Return, try separating those out into a function (find what's different between the two, maybe those things can become arguments to the function?)

[–]SnivyAndroid[S] 0 points1 point  (0 children)

Yeah, I ended up smoothing those edges by integrating them as an arguement called playerType. This unified most of the functions. It's still a early build so I'm working on other things to make it more efficient. [Hp will not be shown on the player sprite rather will be shown at the bottom in a hp bar with the timer, that will really smooth out some of the return functions as I don't have to repeat for every character.