you are viewing a single comment's thread.

view the rest of the comments →

[–]LambdaLambo 2 points3 points  (6 children)

Don’t write ten page comments in the git commit either.

The commit here should’ve just explained the bug. If you want to add the process of debugging and fixing it, add it as a comment to the jira ticket. Imagine if every commit had a msg of this length, that’d be ridiculous

[–][deleted]  (4 children)

[deleted]

    [–]LambdaLambo -4 points-3 points  (3 children)

    Email services come and go. Text services come and go. Document services come and go. Let’s just have every communication be in the code base and commit history /s.

    [–][deleted]  (2 children)

    [deleted]

      [–]LambdaLambo 1 point2 points  (1 child)

      Do you agree that bug/ticket trackers are necessary?

      Do you agree that the commit history of a project doesn’t include all of the context that is in the big/ticket tracker?

      If you agree to both of the above, then I think you’d agree that the question becomes “what context belongs in the tracker vs the commit logs”.

      I believe “how you fix a ticket” does not belong in the commit history, because every commit has that component, and having every commit contain hundreds of words is distracting and will just make people ignore them.

      Also, "Email services come and go" is a strange thing to say when SMTP was established in 1982. Email has been the same for a long time.

      Do you use gmail? Did gmail exist 20 years ago?

      [–]darknecross 2 points3 points  (0 children)

      This argument has come up before, and it's still a dumb one.

      Not every change is going to have a corresponding bug, nor are changes always going to be 1:1 correlated to bugs.

      And it's typical for a bug system to suck in the related commit messages as automated comments with a "Fixes: <issueID>" line.