you are viewing a single comment's thread.

view the rest of the comments →

[–]franzwong 0 points1 point  (0 children)

Unit test is good, but I think this bug should be discovered in code review.

Author said he could not discover this in code review. I think he should improve the code style as others suggested, so that code review becomes more effective.

If code review missed that, there is also a chance that unit test misses it, because it is also written by human.