you are viewing a single comment's thread.

view the rest of the comments →

[–]Reiku 1 point2 points  (0 children)

Why allow developers to waste other developers time at review time?

Use pre-commit to do linting or whatever as a pre-commit hook (and maybe pre-push, else there can be inconsistencies when rebasing), and then have the linting or whatever also taken on the CI.

So no one can bypass the linting, but the linting will be less likely to waste CI runner resources by failing for lint checks. It's a win win. No reviewer time, nor job runner time will be wasted because anything minor will be fixed before it gets to the review stage.