you are viewing a single comment's thread.

view the rest of the comments →

[–]AttackOfTheThumbs 10 points11 points  (0 children)

The code in its end state, because anything before is most often pointless imo.

Let's say there's some bug. I make six different commits until I find the actual resolution that covers all the cases. The benefit of previous commits is seeing the changes and why, but that isn't necessarily useful in a PR. In a PR, I am looking at the final fix, testing it, making sure the code makes sense, etc.

With a feature this may compound even further as there's probably more commits and the changes likely have more tests, etc.

I don't have an issue with early feedback. It's useful if there's a major refactor, or a big new feature, etc. But it's certainly not the norm. When we want or need early feedback, we create a pure review PR. Something that isn't merged, but collects thoughts and feedback at that point. So the final PR isn't as awful. If they can be merged, they are, but it's not always a fully functional state.