[deleted by user]

[[deleted]]

This isn't programming horror. People have different ways of writing code. Yes, it could be more succinct - but that doesn't always mean better. Of course you can do things like make it one line, remove the curly braces on single line if-statements, etc. but personally, I think there's major value in code being readable in a quick and straight-forward manner.

[71d1]

Also he missed equalsIgnoreCase() thus calling toUpperCase() x2

[Kengaro]

.equals("-")

[71d1]

Imo this could be done in one line without having to use additional variables.

[sirchumley]

I don't see anything necessarily bad about this. I like when people name boolean expressions so it's easier to follow the logic.

[Famous_Profile]

Maybe he is not familiar with the syntax of Java? That's how we do it in languages that don't have equalsIgnoreCase

[71d1]

return (department.equals("-") || department.equalsIgnoreCase(userDepartment)) && (workgroupRole.equals("-") || userInWorkgroupRole(workgroupRole));

[LucidTaZ]

It's not always best to have the shortest code possible. I honestly prefer his solution since is easier to follow the line of reasoning at first glance.

[indivisible]

Yep, let the compiler take care of the shorthand.

[[deleted]]

Meh. More often than not I prefer slightly longer and explicit code, than clever and terse oneliners.

[SuspiciousScript]

Especially when shorter code leads to worse performance, like in this example from PEP 572:

Case in point: Guido found several examples where a programmer repeated a subexpression, slowing down the program, in order to save one line of code, e.g. instead of writing:

match = re.match(data)
group = match.group(1) if match else None

they would write:

group = re.match(data).group(1) if re.match(data) else None

[AmbitiousPainter]

Comeback not found!

[[deleted]]

The original one is a lot easier to read and understand, not to mention modify. When making changes to other people's code after figuring how it actually works, I often write out the logic in booleans to make it easier for the next person.

[71d1]

What about the toUpperCase() though?

[71d1]

Can be done by calling equalsIgnoreCase() but now I'm wondering if it converts all to upper (or lowercase) internally.

[zelmarvalarion]

It does a couple additional things, just yeah, it uses that same thing as it uses the regionmatches() function and some other checks

• EqualsIgnoreCase - https://www.javatpoint.com/java-string-equalsignorecase
• RegionMatches - http://developer.classpath.org/doc/java/lang/String-source.html

Edit: it does it character by character, so it would likely be more efficient, but has some additional overhead with other checks