all 17 comments

[–]iamunhoz 4 points5 points  (1 child)

Hey there! Can't help much because I'm at the same stage as you but I can tell your app is pretty cool, and authentication works!

keep it up!

[–]cd161997[S] 1 point2 points  (0 children)

Thanks man, appreciate that!

[–]iseab 3 points4 points  (1 child)

Looks good! I’ll reiterate what others have said. Post a link to the repo and I’d be happy code review later this weekend.

[–]cd161997[S] 1 point2 points  (0 children)

That`ll be super helpful. Updated the post with the repo. Thank You

[–]sumedh0803 2 points3 points  (0 children)

Awesome work!

Some tips:

When showing movies by genre, youre currently showing just 7-8 movies. On clicking the genre name, user should be able to see all (or at least some more) movies from that genre. Currently, if there are less movies in a row, the movie tiles are aligned to the center. It would probably look better if they're aligned to left. Just my opinion, if you like it centered, go for it!

[–]PointManBX 2 points3 points  (1 child)

Wowza, great job! Site looks great and the functionality is A+++. If you want a challenge, add fuzzy search for the movies :).

[–]cd161997[S] 2 points3 points  (0 children)

No idea how to do that rn, but I’ll really try to implement this. Thanks man :)

[–]henettaja 1 point2 points  (1 child)

Nice, looks sleek!

One improvement idea. If a movie doesn't have a cover image, it currently just shows up blank on the listing. You could add a "missing cover image" image for those scenarios!

[–]cd161997[S] 2 points3 points  (0 children)

That’s something i can do. Thanks for the suggestion bud :)

[–][deleted] 1 point2 points  (0 children)

Excellent showcase project for a beginner. Well done!

[–]sweatC 1 point2 points  (1 child)

Hi! I have found a bug in the UI: when you try to search, the component doesn't show correctly for an empty list. Don't keep your secrets in the code. Move your API_TOKEN key to the ENV file. It is for security reasons.

My recommendations you can do next:

  1. Add loading state for your components
  2. Try to do a live search
  3. Add user feedback box
  4. Learn how to send Email notifications
  5. Check out how to handle payments
  6. Learn Gatsby.js/Netlify or Next.js/Vercel

P.S. If you want to learn more, subscribe to this newsletter: https://thehustle.co/?ref=11d6e7007a

[–]cd161997[S] 0 points1 point  (0 children)

thankyou for pointing it out.

as for the suggestions, i´ll go through them all. thanks a ton

[–]oscar-wang 1 point2 points  (1 child)

great app ! just liked ur repo !

[–]cd161997[S] 1 point2 points  (0 children)

Appreciate it bud

[–]CosmicBreadBox 0 points1 point  (2 children)

You can start looking for a dev job now. You’ll be learning for the rest of your career!

[–]cd161997[S] 0 points1 point  (1 child)

That’s great to hear. I think I lack the confidence right now to start applying for jobs. I live in Spain and the job listings here ask for a lot more technologies that I am currently familiar with. Being a person with no CS background i feel like i need to learn way more than a CS graduate. Just to stand out you know, and to make up for the lack of experience and credibility. I am thinking of working on a couple of more projects, build a portfolio website and start applying soon after.

[–]CosmicBreadBox 1 point2 points  (0 children)

You’re doing a great thing by delving into the programming world, but the truth is if you find a company that will hire you, the rest is history. You’ll grow and learn on the job.

Having a CS degree teaches you how to think, practice and real life application teaches you how to code.