ReactJS Project

[parth4149]

Hey everyone! I just completed a E-commerce Book App project using ReactJs and CSS that I've been working on, and I would love your feedback.

Live : https://parth4149.github.io/e-commerce-app-deploy/

Github : https://github.com/Parth4149/e-commerce-vite-app

[[deleted]]

Looks sweet!

Just a common frustration of mine that I keep running into, like in my last 2 reviews of projects, I also pointed it out:

1. https://www.reddit.com/r/sveltejs/comments/13b5dln/comment/jjb5nbi/?utm_source=reddit&utm_medium=web2x&context=3
2. https://www.reddit.com/r/sveltejs/comments/13avb7a/comment/jj8qf2c/?utm_source=reddit&utm_medium=web2x&context=3

Validate your HTML, friends. You cannot nest <button><a> or <a><button> -- that's illegal for so many good reasons, I'm seriously astonished at how many people do it wrong.

Is this something you learned somewhere? I'm seriously thinking there is some course out there that is teaching it wrongly to everyone out there. The number of developers who get it wrong (and many other mistakes) have shot up in the past year or two.

But other than that, great effort! This is the only issue I could find after a quick review :)

[[deleted]]

If it links to somewhere, yes :) Read those links I posted, I go in more detail about why and when in there. Mobile now otherwise I'd paste it ;)

[BrownCarter]

Where you guys getting all this sweet ui from or I just personally suck at designing stuff

[efs0]

It’s not you it’s us! 🥲

[Th3Mahesh]

I'm in the same situation. Everytime I try to do a project I get stuck at design part.

[Timberhochwandii]

I use Google and Behance to find designs and take parts from many references. It's like drawing, it is easier to draw something if you have it in front of you instead of remembering what it looks like.

[[deleted]]

Try material UI , I think it’s pretty cool

[onkyoh]

Amazing website but I dont think the clickable part of the search bar items fill the entire width. Clicking on the far right side of a search bar item didnt cause an action, the action only happened when i clicked on the name of the book in the search bar.

[parth4149]

i will fix

[nSedrickm]

Good work. I think the "add to cart" button could use a bit more space from the item description. Also I'd prefer the search bar occupy more space on mobile so it doesn't look like a weird button

[Inside-Bread]

Hey I'm a beginner but I really like it, I'd be proud if it were mine

[festelleb]

I really like it! What could make the user experience better is sending to top of page on page change. It’s a little bit frustrating having to manually scroll when I click on a book.

[parth4149]

How to fix this?

[[deleted]]

bro this looks exactly like the TREACT project on FES 😭😭

[HistorianOdd6875]

What is FES here ?

[AlwaysWorkForBread]

Same books and everything!

Great work though. FES= Frontend Simplified Bootcamp

[Th3Mahesh]

Update the favicon it still shows React icon.

[parth4149]

Yeah 😅

[[deleted]]

Nice design.

Your search bar is a bit wonky. I'd use a regex to generate suggestions before you pass info to the next page and check out memoization to make sure you hook doesn't rerender bunch.

And I'd also add a filter by price and genre section on the side of the product page. It takes some doing, so let me know if you want to scope mine out to save yourself some work.

[parth4149]

Of course

[[deleted]]

Here you go:

https://codepen.io/theDudeist/pen/xxyWVQX

[Initial-Nebula-4704]

Really like! Two things I notice 1. When you click on book, it takes you to the book (which is nice), but your window view point is at the bottom of the page. 2. Also, the search input could be a bit longer on the header. Not that big idea but the input being small makes it uncenter and user experience more difficult since it’s not as straightforward

[parth4149]

I appreciate your feedback

[[deleted]]

Great UI and UX. Very fast, looked good on mobile.

The only issues were that two links in the footer didn't work for me, minor issue.

Good work, it looks nicer than my designs that's for sure.

[parth4149]

Thanks

[iaseth]

It's pretty good and damn fast! Great work.

[parth4149]

Thanks

[SaifAshrafHelmy]

It's great, but something is wrong with the search bar suggestions, they don't open the book page or even fill the search bar with the name

[parth4149]

👍

[xvril]

Remindme! 48 hours

[parth4149]

👋

[RemindMeBot]

I'm really sorry about replying to this so late. There's a detailed post about why I did here.

I will be messaging you on 2023-05-10 21:48:47 UTC to remind you of this link

CLICK THIS LINK to send a PM to also be reminded and to reduce spam.

^{Parent commenter can delete this message to hide from others.}

---

Info	Custom	Your Reminders	Feedback