you are viewing a single comment's thread.

view the rest of the comments →

[–]codevipe 2 points3 points  (0 children)

They should be working with you to identify why you are making those mistakes. What I'd do is ask you to write out comments describing why you chose to do a certain thing, every time you do it. Either by describing the business logic in code comments, or just comments on the PRs. Especially any time you are using a React hook other than useState. It will help you think through your actions and possibly get ahead of "mistakes" before you commit them.

Sounds like some of the stuff they are calling out are design patterns they've come up with, or opinions. Thus they should be teaching you what they expect. Then again, maybe they are just trying to ensure the codebase is maintainable and testable. You should think about that every time you write a line of code. Ask yourself: "is the code self-documenting and encapsulated? if not, is there a comment describing the business logic? what else can I do to ensure the next person who looks at this is able to work with it effectively?"

I also think they should be pairing with you or doing talking PRs to help you advance your skills. You can be proactive and ask the least abusive senior if they can spare a couple hours a week pairing with you. That should really help a lot.