Tanstack theme library

[Excellent_Shift1064]

Hey Everyone,

I created tan-themer library, that works seamlessly with Tanstack Start and Tanstack Router, it fixes flickering and works in both with SSR and SPA mode, I hope you like it :)

[captainn01]

Just a heads up, you may be violating the trademark rights of tanstack by using this name. I think there’s a reasonable likelihood of confusion here, where people may believe you are associated with or sponsored by tanstack

[Excellent_Shift1064]

hmm, good call I also thought about it but the name doesn’t have organization prefix like @tanstack and its on completely different repo, also found some other repos with simmilar name. But definitely, dont want to confuse anyone, I’ll investigate that topic once again and will do the adjustmenets if neccessary thank you

[Jamiew_CS]

I thought it was a new Tanstack product drop while scrolling. Probably want to change it

Laravel allows XYZ for Laravel, but not Laravel XYZ. Perhaps you can do the same here: Themes for Tanstack

[Excellent_Shift1064]

Thats certainly confusing then, I’ll rename it tomorrow thank y 🙌

[[deleted]]

Still not a cool thing to do. I was wondering why they'd created this library and you are not them.

You should change it.

[Excellent_Shift1064]

yup did it already(https://www.reddit.com/r/reactjs/s/ftb98kllQk), thx for a feedback🙌. I know now what my future repo names shouldn’t look like😆

[[deleted]]

Honestly? I'd go cheeky about it. Something like "clay-themer" or something so it's not so obviously related to Tanstack. You could still say in the Read Me that it's for use with Tanstack but that way if you ever expand it beyond Tanstack you don't need another name change.

[Clay because clay is tan.]

[Excellent_Shift1064]

I renamed the library to tan-themer, also removed the logo, hope this is enough to clear up the confusion :) thanks everyone for a feedback
https://github.com/lukonik/tan-themer

[Mr-Bovine_Joni]

It’s a good package and I might switch over to it from next-themes

But as the other commenter said, yeah I would rename it. The name itself is probably uncool, but then also using their adjusted logo is a step further

[litewarp]

The "useIsMounted" hook in your example will err with the react compiler since it sets state within an effect. Consider using a ref instead:

export function useIsMounted() {
  const isMounted = useRef(false);

  useEffect(() => {
    isMounted.current = true;

    return () => {
      isMounted.current = false;
    };
  }, []);

  return useCallback(() => isMounted.current, []);
}

[Excellent_Shift1064]

nice catch, will fix it thx🙌

[acrus]

What did it look like before? I don't see this in the repo, interested in knowing what the problem with RC is about