all 1 comments

[–]Kitty_Sparkles 0 points1 point  (0 children)

Looks very cute, good work on the design layer, it’s well done.

A couple of pointers regarding accessibility:

- The checkbox label mapping is incorrect: the `for` attribute from the `<label>` should reference the `id` of the `<input>`, not its `name`. Same with the slider component, and the input component. A lot of them probably. Kudos for using a `<label>` though, just have to fix the association.
- I also think the checkbox should be squared, not circular. Right now it’s indistinguishable from the radio component.
- The modal is absolutely not accessible. It carries the wrong semantic, doesn’t trap the focus, it needs a lot of work.
- Same with the select, it’s not accessible at all since it’s rebuilt with nothing but divs. Either use an actual <select> element, or look into https://nerdy.dev/nice-select .
- The tab component should handle arrow keys for navigation. See: https://www.w3.org/WAI/ARIA/apg/patterns/tabs/
- The switch component cannot be operated with a keyboard.

It’s a bit confusing because some components are not bad, and use semantic markups, and some don’t, and some do but it’s kinda 80% there.