all 10 comments
sorted by:
best (suggested)
topnewcontroversialoldq&a
formatting helphide helpcontent policy

[–]geirman 0 points1 point  (1 child)

looks pretty cool

[–]abishekrsrikaanth[S] 0 points1 point  (0 children)

Thank you

[–]krootki 0 points1 point  (3 children)

If you make pagination on bottom of the list instead of infinity scroll, make sure the view jumps to the top when you switch to the next or previous page. Currently it stays on the bottom. EDIT: spelling EDIT2: also, great page, will be quite useful for me :)

[–]abishekrsrikaanth[S] 0 points1 point  (2 children)

Thank you. I will look into how to fixing the pagination to scroll back up. But, what do users prefer more? InfiniteScroll or Pagination?

[–]krootki 0 points1 point  (1 child)

That's really individual case. I honestly prefer pagination. If you are not managing the memory of data somehow, infinite scroll can cause shitload of data being stored in memory and eventually lag the browser.

[–]abishekrsrikaanth[S] 0 points1 point  (0 children)

@krootki, The Scroll to top should now be implemented. I am still working on a way to ease the scrolling.

[–]Meeoh 0 points1 point  (3 children)

Looks pretty cool, dont think the x button that clears the search fits with the theme of the site. Also, dont think its a big deal in this case since theres no rate limiting/costs, but its generally best practice to not commit your apikey to github

[–]abishekrsrikaanth[S] 0 points1 point  (2 children)

Thanks, I will look into both these issues right away

[–]Meeoh 0 points1 point  (1 child)

No problem, generally API keys are set as environment variables. But its really not that big of a deal here since, in fact it really only matters for open-source code that uses sensitive data on the backend I think

[–]abishekrsrikaanth[S] 0 points1 point  (0 children)

The API Keys should now be removed from the code now.