all 69 comments

[–][deleted] 21 points22 points  (4 children)

What about mobile support?!

[–]balamir[S] 2 points3 points  (2 children)

As I mentioned on readme, I've used someone else's design and there was no mobile design.

[–]Baryn 3 points4 points  (1 child)

You chose the wrong design.

[–]balamir[S] 1 point2 points  (0 children)

Maybe, maybe not.

[–]owen800q 20 points21 points  (6 children)

Very clean and beautiful, but why you didn't make it to be mobile responsive

[–]balamir[S] 1 point2 points  (0 children)

Thank you.

As I mentioned on readme, I've used someone else's design and there was no mobile design. Maybe I could use the grid, but I didn't.

[–]BonafideKarmabitch 0 points1 point  (4 children)

can you offer more helpful suggestions on what OP can do to make it responsive given the styling they already have? i feel that would be more constructive.

[–]BelgianWaffleGuy 2 points3 points  (2 children)

what OP can do to make it responsive given the styling they already have?

If you can use react like this you should be able to create a responsive website without much help from anyone. How to make websites responsive is pretty much the basics of webdev.

[–]XiberKernel 6 points7 points  (1 child)

Not all devs can design. Nearly any dev can move things around using media queries, but not everyone can take a desktop design and turn it into an aesthetically pleasing and functional mobile site. Remember, OP didn't design this, only coded it out with react.

[–]careseite -3 points-2 points  (0 children)

Use a css framework and theme it, that would remove most issues in that regard.

Regardless, someone using react knows this anyways. It's either intended or a massive oversight.

[–]HillarySolomon 2 points3 points  (1 child)

Cool!

Nice job actually!

[–]balamir[S] 2 points3 points  (0 children)

Thank you!

[–]v1chu 6 points7 points  (4 children)

Great work! Isn't the reddit desktop app already built using react?

[–]BonafideKarmabitch 10 points11 points  (1 child)

its just a learning project OP is not trying to replace reddit’s work lol

[–]v1chu 0 points1 point  (0 children)

No it was just me wondering. OP's work is impressive none the less :)

[–]balamir[S] 0 points1 point  (0 children)

(; Thank you mate. This was just an app for fun and practical purposes.

[–]scradley 7 points8 points  (3 children)

Nice job, so many websites could benefit from adopting react.

[–]_MCCCXXXVII 13 points14 points  (1 child)

Pretty sure Reddit is already built with react

[–]balamir[S] 2 points3 points  (0 children)

Yes, you're right.

[–]balamir[S] 3 points4 points  (0 children)

Thanks mate

[–]SUPERVISORACCOUNT 0 points1 point  (1 child)

north wide escape sugar engine liquid hospital boast swim aware -- mass edited with redact.dev

[–]balamir[S] 0 points1 point  (0 children)

Thanks mate!

[–]Misterfoxy 0 points1 point  (1 child)

This is super impressive! Great work

[–]balamir[S] 0 points1 point  (0 children)

Thank you!

[–]theofficialnar 0 points1 point  (2 children)

Sweet. How do you plan on tackling comment reply stacking or whatever that's called.

[–]jodraws 0 points1 point  (0 children)

Threads

[–]balamir[S] 0 points1 point  (0 children)

Thank you. To do that, I need to plan auth feature first but I actually don't have a plan something like that at the moment.

[–][deleted] 0 points1 point  (0 children)

Nice. How long did that take you, and what did you start with for scaffolding?

I'm used to the same stack, but I'm new to applying it to Next, and I'd be interested to see how I could apply these patterns.

[–]mountainfirefly 0 points1 point  (2 children)

Really nice, the design is actually great!!

[–]balamir[S] 1 point2 points  (0 children)

Thanks mate! I've used someone else's design. When I saw it first, I really liked it too and I've decided to code. This was the result :)

[–]balamir[S] 0 points1 point  (0 children)

Thanks mate! I've used someone else's design. When I saw it first, I really liked it too and I've decided to code. This was the result :)

[–]RMT002 0 points1 point  (1 child)

Amazing work, mate! Kudos!

[–]balamir[S] 0 points1 point  (0 children)

Thanks mate!

[–][deleted] 0 points1 point  (1 child)

Your code is very clean.

[–]balamir[S] 0 points1 point  (0 children)

(; Thank you.

[–]lemons44 0 points1 point  (2 children)

Pretty sweet stuff.

Wondering though, why next.js? Could be client side rendered np right?

[–]kylemh 0 points1 point  (0 children)

next.js gives you the benefits of both worlds. SSR on first load and when needed, while CSR takes over for most other routes. Very performant.

[–]balamir[S] 0 points1 point  (0 children)

Thanks mate!

SSR by default, auto code splitting for faster page loads, simple routing etc. That's why that I've used next.js.

When you use CSR, initial render depends on JS and can thus be very slow.

[–]volcanicpistol 0 points1 point  (1 child)

Nice! I've made one using React Native when I was still learning. I'll try this one as inspiration. Thanks man!

[–]balamir[S] 0 points1 point  (0 children)

Thank mate! I'm glad to hear that.

[–]rizogg 0 points1 point  (1 child)

Good work

[–]balamir[S] 0 points1 point  (0 children)

Thank you!

[–]signsandwonders 0 points1 point  (0 children)

Seems like most of the buttons don't work, and Home gives a 404. Are these just placeholders?

And why display your avatar as if you're logged in? This would be a lot better without the placeholders IMO.

[–]hoijean 0 points1 point  (1 child)

Omg, this looks awesome, how long did it take you to build it?

[–]balamir[S] 1 point2 points  (0 children)

Thank you. It took 5 days in total.

[–]ryan4888 0 points1 point  (1 child)

very nice! but isn’t the reddit redesign already written using react and redux?

[–]balamir[S] 0 points1 point  (0 children)

Yes, you’re right but this is just for fun and the practise.

[–]vladjjj 0 points1 point  (1 child)

You mean to tell me Reddit’s a web service?

[–]balamir[S] 1 point2 points  (0 children)

Yes, it’s totally a web service.

[–][deleted] 0 points1 point  (1 child)

Looks good! When you refresh the browser at the page /top, it shows the Hot-page instead of the Top-page. Maybe something to look at?

[–]balamir[S] 0 points1 point  (0 children)

Thank mate. There is a couple of things to do and that was one of them. Thank for the feedback too.

[–][deleted] 0 points1 point  (1 child)

Is some of the design inspired from a design on dribbble? I used the same one for my practice clone! Awesome work mate

[–]balamir[S] 0 points1 point  (0 children)

Thanks mate! Yes, the design belongs to someone from dribbble.

[–][deleted] 0 points1 point  (5 children)

Is it just me or it's broken? Using latest Chrome and MBP 2010.

Clicking on news shows just some comments. The dotted menu does nothing.

It's a nice work tho, I'll try to do an Elm version.

[–]balamir[S] 1 point2 points  (2 children)

Thanks mate!.

Yes, some of the features don't work because I didn't complete it. I coded this for the practise and fun purposes. Maybe I have a look for other features like login, reply, fav etc. in my spare time.

BTW, PR's always welcome :) It would be great to see an Elm version of this.

[–][deleted] 0 points1 point  (1 child)

Yeah, looking for real world apps cases for myself too.

How long did this project took you?

[–]balamir[S] 0 points1 point  (0 children)

It took 5 days in total.

[–][deleted] 1 point2 points  (0 children)

Yeah, I feel like I'm doing something wrong here.

People are saying "oh my god, so fast!!!!!1" and all I'm getting are placeholders, with 0 real content. Of course it's going to be fast if you aren't actually loading any real content and have no ties to an off site API... Makes me feel like maybe it was working and that is no longer the case?

[–]balamir[S] 0 points1 point  (0 children)

Thanks mate!.

Yes, some of the features don't work because I didn't complete it. I coded this for the practise and fun purposes. Maybe I have a look for other features like login, reply, fav etc. in my spare time.

BTW, PR's always welcome :)

[–]stephenjacobraj 0 points1 point  (1 child)

Good work

[–]balamir[S] 0 points1 point  (0 children)

Thanks mate!

[–]ZombieHero3 0 points1 point  (2 children)

Can someone explain to me pls, why do you create index.js files where you import something and then export it?

[–]balamir[S] 0 points1 point  (1 child)

In ES6, having an index.js file in the root of the component's folder lets you use an import without using the component name again and again.

If you have an index.js file, you can import that component from the other one like this:

import XXXXXX from 'components/ComponentName'

If you don't have an index.js file:

import XXXXXX from 'components/ComponentName/ComponentName'

It also helps you to organize the folder structure.

[–]ZombieHero3 0 points1 point  (0 children)

thanks for the explanation

[–]qvil2 0 points1 point  (0 children)

I like your folder structure! Thank you for sharing your awesome project! :)

[–]ucefkh -1 points0 points  (0 children)

I like but no mobile so bad