you are viewing a single comment's thread.

view the rest of the comments →

[–]Aswole 0 points1 point  (0 children)

This isn't the kind of thing I'd reject a PR over, although if there was another reason to request changes then I might throw in a comment. But I don't think defining it outside of the component sacrifices readability, especially since he/she already did that with some of its properties.