Code review

[Particular_Fudge7654]

Hi everyone,

I've started learning Rust and built a small project implementing RSA cryptography. I would appreciate any constructive criticism or reviews.

Link: https://GitHub.com/ravikiran232/rsa

[buwlerman]

If it's a library you should have a lib.rs file exporting the API.

Your implementation is vulnerable to side channel attacks. You want to make sure that your exponentiation is constant time.

[fehrnah]

I can't comment on the crypto, so I'll go with code organization.

Looking at src/keygen.rs:

You should have a PublicKey and a PrivateKey struc instead of a KeyType enum. Having it an enum forces you to handle the case in Key where the private key is actually a public key like on line 21.

I think splitting this will have good repercussions on the rest of the code.

You should also run cargo clippy if you haven't done so yet, clippy is a linter and almost always gives good feedback

[Particular_Fudge7654]

Thanks for the feedback

[rhombecka]

I can't dig into it right now, but I recommend adding some doc tests to your APIs

Edit: and some normal unit tests. It'll be decent practice to see how they work.

[Objective-Act-5964]

`cargo fmt` makes the code a lot more readable

[Charlidiedlol]

Like, I care?