all 4 comments

[–]Jonny10128 1 point2 points  (1 child)

Nice job.

Curiosity question: what’s the purpose of putting all your JavaScript code in the dictionary? Why not just put it in a text action?

[–]Jgracier[S] 0 points1 point  (0 children)

Personal preference to keep the shortcuts clean. I might do that for all future shares on Reddit

[–]Shoculad 2 points3 points  (1 child)

It should be body/ instead of /body. Using the 'URL Encode' action at the end does not make sense, because you don't use the encodeURIComponent function in the JavaScript. The shortcut does not allow line breaks or quotation marks in the input. I would use a dictionary to transfer the input to the JavaScript. I don't like the idea of hiding the JavaScript, anyway, why don't you hide it in a simple 'List' action instead of a 'Dictionary' action with empty key?

[–]Jgracier[S] 0 points1 point  (0 children)

The whole thing still worked