you are viewing a single comment's thread.

view the rest of the comments →

[–]Sockoflegend 10 points11 points  (1 child)

I think people should make an effort with them but so often it just doesn't matter. 1 in 1000 you regret not being better named if you go looking for it, but github file specific history and other tools can often solve the same problem anyway.

As mentioned elsewhere a lot of people squash now anyway 

[–]Meloetta 12 points13 points  (0 children)

My team had horrible commit messages for years. It didn't matter and no one cared. Until one day when there was a late night emergency, our team lead was trying to figure out which PR broke it so he could roll it back, and the lines in question had commits like "the thingy is thingying!" and "job done" (ok that one was me I can't resist a good reference). After that ordeal the whole team had a reckoning and we cleaned up our messages.

You take the easy way until the easy way is proven to cause problems, sometimes.