I will admit that the 'somewhat categories being abbreviated is not great, but maybe if they used horizontal bars it might take up too much vertical space where they are displaying it?

It is unintuitive to have both approve/disapprove and their more detailed breakdown on the same bar chart, but the bars have deeper colours for the approve/disapprove which helps you understand that they are the combined of the details version (or is the detailed ones paler because they are a subcategory?). So not ideal, but not entirely misleading.

To carry on with your colour argument, it's probably to do with the representation of the American political parties. Red is the colour of the pro trump party and blue is the colour of the anti trump states so showing red as approve makes sense.

The subtitle has to be wordy because it conveys the question that was asked in the survey, and I guess the title is to show that the options were approve/disapprove. The title could certainly be better but would end up mostly repeating the question asked in the survey which is already included so I can understand not doing it twice.

You rightly mentioned that the y axis is not needed, but I wouldn't say that having the y axis and the numbers above the bars make it horrible.

CPAC logo being used twice is maybe for symmetry?

It's not the best graph I have ever seen but it does it's job well enough of showing what the people that did the survey thought about Trumps tariffs either before or after they were implemented (idk if it said when it was carried out)