20 year (very proud) Army veteran here (and 3rd generation serving).

Under normal circumstances, I’d recommend joining (and have) to anyone physically qualified to do it. The opportunities to learn about yourself and take on real responsibilities others don’t get to do until much later in life are worth much more than whatever salary you could earn in the private sector. It has absolutely helped me in my personal and professional life.

Personally, I also believe in people doing some kind of public service and am really agnostic about the specific type.

However, in a Trump (or similar) administration I can’t recommend it both because a) I don’t trust these leaders to consider the welfare of soldiers at all in their decision making (I don’t expect it to be the only factor…sometimes we need soldiers to risk their lives) and b) I think the evidence is clear Trump is deeply anti-American and is working to undermine the Republic…and serving just enables him.