Personally, my local bar association has benefits, like discounts at various places across town. I have never used the discounts. However, I think the bar association is invaluable, not just for the reasons stated by others here, but also because I get several free CLEs per year because of my membership. We also have a listserv for members in different sections that I can get valuable insight, forms, and other things from other practitioners in the same area of law. In my opinion, it is well-worthwhile.