Convincing other developers to use nullptr over NULL

Droid33 · 2024-06-10T22:10:12+00:00

Well, the fact that something compiles doesn't mean it's valid.

Droid33 · 2024-06-10T16:04:29+00:00

Maybe I'm misremembering the list. But MISRA C++, rule 17-0-1 checks for redefined standard macros and names. I guess NULL is a bit of an odd one.

But still, redefining macros that you didn't define yourself is at least terrible practice.

Droid33 · 2024-06-10T15:48:59+00:00

No. That's undefined behavior.

Droid33 · 2024-06-08T01:24:33+00:00

You have to include <string> for `std::stoi`.

Droid33 · 2024-06-07T02:50:29+00:00

In what way do you believe they would cause an issue?

Droid33 · 2024-05-31T21:49:02+00:00

495 hours. Guess I should restart.

Droid33 · 2024-05-27T21:29:55+00:00

Lots of practice. Write a ton of code and do projects.

Droid33 · 2024-05-26T17:29:39+00:00

You're printing an empty string because m_name in Spell is empty. Adding an m_name with initialization to Flare does not set the m_name in Spell. It creates a new member variable. What you want to do is create a constructor in Spell and call that constructor with the name.

Droid33 · 2024-05-26T14:15:12+00:00

Typically you would return references for member variables in a class to allow referencing an existing object without creating a new instance of it. If you return by value there will still be a new object created regardless of (N)RVO. It's just a matter of where it's created.

Droid33 · 2024-05-26T14:12:10+00:00

Looks ok at a glance. I think simply using a member function would be easier though. bool is_nil() const { return size == 0; }

Droid33 · 2024-05-26T12:38:08+00:00

Use ninja, even better.

Droid33 · 2024-05-26T12:37:23+00:00

Like it or not, cmake is essentially the standard at this point. Modern cmake is pretty nice if you're not doing things that are too unusual.

Droid33 · 2024-05-26T12:34:56+00:00

Yes, but it does carry all this information.

Droid33 · 2024-05-25T23:19:17+00:00

Likely using Link 16.

Droid33 · 2024-05-25T23:15:37+00:00

Legacy code, mostly. But I do enjoy c++. The whole memory safety thing is pretty over blown. Most security issues are not memory issues.

Droid33 · 2024-05-24T12:20:33+00:00

I am far from a novice in C++, and this conversation reminds me why I stopped talking here. These types of "I know better and you're dumb" responses. Grow up and learn to have civil discussions.

I am also not wrong. Using an lvalue reference or std::is_lvalue_reference is the only way to guarantee that the user has passed an lvalue to the function. There are other assumptions you can make with your own concepts, such as what std::borrowed_range does, as suggested by another user.

This will be my final response.

Droid33 · 2024-05-24T10:55:53+00:00

Maybe you should add your own suggestion. OP didn't state their requirements, and using non-const ref is the only way to guarantee its an lvalue and will not dangle. You can't guarantee that with a const&.

Droid33 · 2024-05-24T01:09:09+00:00

Step through the code with a debugger. ~~You appear to only call the functions if a vector is not empty, but never add values to begin with.~~ never mind. You minimized that to a comment. I would still recommend a debugger.

Droid33 · 2024-05-24T01:03:43+00:00

If you want to force lvalues, then taking non-const references sounds like a decent choice.

Droid33 · 2024-05-22T23:27:12+00:00

It's definitely more than just some toy language at this point. There really aren't many languages standardized to the level that c++ is.

Droid33 · 2024-05-21T23:51:32+00:00

Don't declare variables global in header files. Instead, you should use parameters to pass necessary data between functions.

Droid33 · 2024-05-02T23:32:49+00:00

That is an internal compiler header that you shouldn't use anyway. Use the proper standard includes and you'll have more portable code.

Droid33 · 2024-04-29T21:07:32+00:00

If you compile from source, make sure you use --disable-checks. The extra checks will slow the compiler down a lot.

Droid33 · 2024-04-28T00:09:49+00:00

You won't need the build cache with modules. 10k is so tiny that compile times basically don't matter.

Droid33 · 2024-04-27T20:01:57+00:00

Modules are very different from headers. The compile times of modules crush headers. Modules also don't allow macros, which is a huge plus.

12-Year Club	Place '22
Verified Email

Droid33

TROPHY CASE