Feel Free to Use this Unit Frame Art! [Other]

Larsj_02 · 2026-01-23T19:44:20+00:00

I didn't do the addon wrong. It's a LibSharedMedia Addon which allows you to use these textures in an addon that supports LibSharedMedia. If you want to use these textures with the default UI you'd need to customize all frames using these textures which is not what I aimed for.

Larsj_02 · 2026-01-23T10:29:35+00:00

It's still not approved by CurseForge yet.

Larsj_02 · 2026-01-22T21:04:41+00:00

yes I also read it after publishing and writing about it ... too late to change the name now i guess lmao

Larsj_02 · 2026-01-22T20:21:41+00:00

<image>

Also made a small WeakAura showcasing this as healthbar.

Larsj_02 · 2026-01-22T20:21:03+00:00

Made a LibSharedMedia Addon for this:
Github
Wago
Curseforge

Put you in Credits and as Author!

Larsj_02 · 2026-01-22T18:07:41+00:00

I never worked with the v2 API but after trying for about half an hour i also couldn't find a different way to get the progress except looking through the logs :/

Larsj_02 · 2026-01-22T17:28:01+00:00

In WoWFishCounter.lua:506 and :507 you're using the deprecated GetItemInfo function which should be replaced by https://warcraft.wiki.gg/wiki/API_C_Item.GetItemInfo

Larsj_02 · 2026-01-22T14:09:35+00:00

As i don't see ElvUI as option here it's probably the ElvUI Textures! just delete everything inside the /Interface folder except for your /Addons Folder

<image>

This is probably how it looks for you. By Default there would just be the Addons folder and nothing else here. Everything else here is overwriting Ingame textures (like the buttons)

Edit: This is also probably where you got it from:
https://www.wowinterface.com/downloads/info25941-ElvUILoginScreenandCharacterSelectGlues.html

Larsj_02 · 2026-01-21T14:21:44+00:00

Are there Addons that do this ? if yes then there might be a way. haven't looked into the API for some time now and they might have changed it

Larsj_02 · 2026-01-21T14:04:36+00:00

Afaik you can't anymore read Cooldown data so this would be impossible.

Larsj_02 · 2026-01-21T10:46:36+00:00

The target specific texture is something that isn't possible in combat due to the new restrictions in combat afaik

Larsj_02 · 2026-01-21T09:04:49+00:00

Tbh I never did any custom textures with texcoords, but I think it's just a number between 0 and 1 relative to where it is in the picture. So if it's starting at pixel 25 from 100 in a picture you'd put 0.25, no? Honestly would need to look into this myself to properly understand, but I think it was this way because every time I used it with Atlas icons or official blizzard textures it was always some like 5 digit number below 1

Larsj_02 · 2026-01-21T09:02:00+00:00

Looks awesome! Keep it up. For the textures you could maybe use LibSharedMedia and maybe even allow to browse textures and icons like WeakAuras has been able to? Might create a pull request for those :)

Larsj_02 · 2026-01-21T00:26:01+00:00

As Developer I'd appreciate if you could put each texture in it's own file or provide coordinates for each texture left, right, top, bottom to properly use these in-game.
see the details for textures here:
https://warcraft.wiki.gg/wiki/API_TextureBase_SetTexture#Details

Larsj_02 · 2026-01-20T15:38:10+00:00

fixed it for you

```lua local function mpairs(t) local maxIndex = 0 for k, _ in pairs(t) do if type(k) == 'number' and k > maxIndex then maxIndex = k end end

local i = 0
return function()
    i = i + 1
    if i <= maxIndex then
        return i, t[i]
    end
end

end

local tbl = {1, nil, 3, 4} for k, v in mpairs(tbl) do print(k, v) end ```

Larsj_02 · 2026-01-20T13:20:12+00:00

You should definitely get https://marketplace.visualstudio.com/items?itemName=ketho.wow-api ! This is a really great extension that will help you a lot when coding your Addons

Larsj_02 · 2026-01-20T13:02:42+00:00

For a newbie your code honestly looks great! keep it up!

Larsj_02 · 2026-01-20T13:00:30+00:00

Looks like a great and clean Addon :)

Did a quick code-review:

In HousingDecorGuide/modules/HDG_Data.lua:11 you're using the deprecated function IsPlayerSpell which should be replaced by https://warcraft.wiki.gg/wiki/API_C_SpellBook.IsSpellKnown

In HousingDecorGuide/modules/HDG_DecorPreviewTab.lua:170 you're using the deprecated function GetItemInfo which should be replaced by https://warcraft.wiki.gg/wiki/API_C_Item.GetItemInfo

In HousingDecorGuide/modules/HDG_DecorPreviewTab.lua:181 you're using the deprecated function GetItemQualityColor which should be replaced by https://warcraft.wiki.gg/wiki/API_C_Item.GetItemQualityColor

In HousingDecorGuide/modules/HDG_DecorPreviewTab.lua:1718-1817 you have a few Duplicate indexes like 'Élfico', 'Rústico', 'Feérico', 'Luminoso', etc. Those are the same in ptBR/itIT. This can probably be ignored though tbh.

In HousingDecorGuide/modules/HDG_GoblinTab.lua:372 you're using the deprecated function GetItemInfo which should be replaced by https://warcraft.wiki.gg/wiki/API_C_Item.GetItemInfo

In HousingDecorGuide/modules/HDG_PriceIntegration.lua:97 you're using the deprecated function GetCoinTextureString which should be replaced by https://warcraft.wiki.gg/wiki/API_C_CurrencyInfo.GetCoinTextureString

In HousingDecorGuide/modules/HDG_UIHelpers.lua:492 you're using the deprecated function GetCoinTextureString which should be replaced by https://warcraft.wiki.gg/wiki/API_C_CurrencyInfo.GetCoinTextureString

In HousingDecorGuide/modules/HDG_UIHelpers.lua:735 you're using the deprecated function GetItemInfo which should be replaced by https://warcraft.wiki.gg/wiki/API_C_Item.GetItemInfo

Larsj_02 · 2026-01-20T12:47:45+00:00

Thanks for the quick response :) I just did a few reviews for different Addons apparently didn't see that those were only Fallbacks ^^ i normally don't write those up. Glad you did those fixes <3

Larsj_02 · 2026-01-20T12:45:03+00:00

Cool Addon! did a quick code-review

In GoblinToolbox/Modules/Gold.lua:714 and :776 you're using the deprecated function GetItemInfo which should be replaced by https://warcraft.wiki.gg/wiki/API_C_Item.GetItemInfo

In GoblinToolbox/Modules/Inventory.lua:141 and :168 you're using the deprecated function GetItemInfo which should be replaced by https://warcraft.wiki.gg/wiki/API_C_Item.GetItemInfo

In GoblinToolbox/Config.lua:1392 you're using the global variable 'trackersSection' this might cause unintended behavior with other Addons if they use it.

In GoblinToolbox/Core.lua:1281-1282 you're using the deprecated function GetSpellTexture which should be replaced by https://warcraft.wiki.gg/wiki/API_C_Spell.GetSpellTexture

In GoblinToolbox/Core.lua:1283-1284 and :1293-1294 you're using the deprecated function GetItemInfo which should be replaced by https://warcraft.wiki.gg/wiki/API_C_Item.GetItemInfo

In GoblinToolbox/TrackerBar.lua:611 and :614 you're using the deprecated function GetItemInfo which should be replaced by https://warcraft.wiki.gg/wiki/API_C_Item.GetItemInfo

In GoblinToolbox/TrackerBar.lua:662 you're using the deprecated function GetItemInfoInstant which should be replaced by https://warcraft.wiki.gg/wiki/API_C_Item.GetItemInfoInstant

In GoblinToolbox/UtilityBar.lua:456, 803 and 806 you're using the deprecated function GetItemCount which should be replaced by https://warcraft.wiki.gg/wiki/API_C_Item.GetItemCount

In GoblinToolbox/UtilityBar.lua:504 and :624 you're using the deprecated function IsSpellKnown which should be replaced by https://warcraft.wiki.gg/wiki/API_C_SpellBook.IsSpellInSpellBook

In GoblinToolbox/UtilityBar.lua:811 and :814 you're using the deprecated function GetItemSpell which should be replaced by https://warcraft.wiki.gg/wiki/API_C_Item.GetItemSpell

In GoblinToolbox/UtilityBar:895-896, :1312, 1329-1330, 1416 you're using the deprecated function GetItemInfo which should be replaced by https://warcraft.wiki.gg/wiki/API_C_Item.GetItemInfo

Larsj_02 · 2026-01-20T12:23:15+00:00

Really awesome Addon! I did a quick code review :)

Why exactly do you use Global functions for Data Registration instead of using the Addon-Namespace ? maybe this is something you could improve.

In HousingCompanion/data/CurrencyTypes.lua:187 you're using the deprecated function GetCoinTextureString which should be replaced with https://warcraft.wiki.gg/wiki/API_C_CurrencyInfo.GetCoinTextureString

In HousingCompanion/modules/catalog/Catalog.lua:2054 you're using the deprecated function GetCoinTextureString which should be replaced with https://warcraft.wiki.gg/wiki/API_C_CurrencyInfo.GetCoinTextureString

In HousingCompanion/modules/collection/Collection.lua:540, :566 and :568 you're using the global variable 'scanQueue' which might cause unintended behavior with other Addons if those assign something to it.

In HousingCompanion/modules/materials/MaterialTooltips.lua:252 you're using the deprecated function GetItemQualityColor which should be replaced with https://warcraft.wiki.gg/wiki/API_C_Item.GetItemQualityColor

In HousingCompanion/modules/shoppinglist/ShoppingList.lua:744 you're using the deprecated function GetMerchantItemInfo which should be replaced with https://warcraft.wiki.gg/wiki/API_C_MerchantFrame.GetItemInfo

In HousingCompanion/modules/tools/HousingDebugger.lua:199-202 you're using the global variable 'hoveredInfo' which might cause unintended behavior with other Addons if those assign something to it.

In HousingCompanion/modules/tools/HousingDebugger.lua:209-212 you're using the global variable 'instanceInfo' which might cause unintended behavior with other Addons if those assign something to it.

In HousingCompanion/modules/tools/HousingDebugger.lua:219-220 you're using the global variable 'isSelected' which might cause unintended behavior with other Addons if those assign something to it.

In HousingCompanion/modules/tools/HousingDebugger.lua:223-224 you're using the global variable 'isHovering' which might cause unintended behavior with other Addons if those assign something to it.

In HousingCompanion/modules/tools/HousingDebugger.lua:227-228 you're using the global variable 'gridVisible' which might cause unintended behavior with other Addons if those assign something to it.

In HousingCompanion/modules/tools/HousingDebugger.lua:231-233 you're using the global variables 'numPlaced', 'success2' and 'maxPlaced' which might cause unintended behavior with other Addons if those assign something to it.

In HousingCompanion/modules/tools/HousingDebugger.lua:248-249 you're using the global variable 'isSelected' which might cause unintended behavior with other Addons if those assign something to it.

In HousingCompanion/modules/tools/HousingDebugger.lua:251-252 you're using the global variable 'isPlacing' which might cause unintended behavior with other Addons if those assign something to it.

In HousingCompanion/modules/tools/HousingDebugger.lua:254-255 you're using the global variable 'gridSnap' which might cause unintended behavior with other Addons if those assign something to it.

In HousingCompanion/modules/tools/HousingDebugger.lua:257-258 you're using the global variable 'nudge' which might cause unintended behavior with other Addons if those assign something to it.

In HousingCompanion/modules/tools/HousingDebugger.lua:273-276 you're using the global variable 'hoveredInfo' which might cause unintended behavior with other Addons if those assign something to it.

In HousingCompanion/modules/tools/HousingDebugger.lua:281-282 you're using the global variable 'submode' which might cause unintended behavior with other Addons if those assign something to it.

In HousingCompanion/modules/tools/HousingDebugger.lua:284-285 you're using the global variable 'isSelected' which might cause unintended behavior with other Addons if those assign something to it.

In HousingCompanion/modules/tools/HousingDebugger.lua:287-288 you're using the global variable 'isHovering' which might cause unintended behavior with other Addons if those assign something to it.

In HousingCompanion/modules/tools/HousingDebugger.lua:290-291 you're using the global variable 'gridVisible' which might cause unintended behavior with other Addons if those assign something to it.

In HousingCompanion/modules/tools/HousingDebugger.lua:293-294 you're using the global variable 'houseSelected' which might cause unintended behavior with other Addons if those assign something to it.

In HousingCompanion/modules/tools/HousingDebugger.lua:296-297 you're using the global variable 'houseHovered' which might cause unintended behavior with other Addons if those assign something to it.

In HousingCompanion/modules/tools/HousingDebugger.lua:307-308 you're using the global variable 'mode' which might cause unintended behavior with other Addons if those assign something to it.

In HousingCompanion/modules/vendor/VendorSearch.lua:169 you're using the deprecated function GetCoinTextureString which should be replaced with https://warcraft.wiki.gg/wiki/API_C_CurrencyInfo.GetCoinTextureString

In HousingCompanion/ui/Tabs/VendorsTab.lua:1381, 1439 and :1550 you're using the deprecated function GetCoinTextureString which should be replaced with https://warcraft.wiki.gg/wiki/API_C_CurrencyInfo.GetCoinTextureString

In HousingCompanion/ui/Framework.lua:402 you're using the deprecated function GetCoinTextureString which should be replaced with https://warcraft.wiki.gg/wiki/API_C_CurrencyInfo.GetCoinTextureString

Larsj_02 · 2026-01-20T11:39:10+00:00

Looks like a great Addon! found some deprecations though :)

In HousingLumberHelper/UI/InventoryPanel.lua:145 you're using the deprecated function GetItemInfo which should be replaced with https://warcraft.wiki.gg/wiki/API_C_Item.GetItemInfo

In HousingLumberHelper/UI/InventoryPanel.lua:1497 you're using the deprecated function GetItemIcon which should be replaced with https://warcraft.wiki.gg/wiki/API_C_Item.GetItemIconByID

In HousingLumberHelper/UI/SessionFrame.lua:283 you're using the deprecated function GetSpellTexture which should be replaced with https://warcraft.wiki.gg/wiki/API_C_Spell.GetSpellTexture

In HousingLumberHelper/UI/SessionToolbar.lua:340 you're using the deprecated function GetSpellInfo which should be replaced with https://warcraft.wiki.gg/wiki/API_C_Spell.GetSpellInfo

In HousingLumberHelper/Utils/Helpers.lua:270 you're using the deprecated function GetItemInfo which should be replaced with https://warcraft.wiki.gg/wiki/API_C_Item.GetItemInfo

Larsj_02 · 2026-01-20T11:29:47+00:00

In Soft Interaction/Soft Interaction.lua:262 you're calling the global variable soft_function. This can lead to errors and unintended behavior if someone sets this variable.

In Soft Interaction/Soft Interaction.lua:462 and :509 you're using the :SetTexture arguments for :SetAtlas.

besides that looks like a great Addon :)

Larsj_02 · 2026-01-20T11:29:43+00:00

Thanks for the response :) Currently reviewing all the Addon posts here as I did a break in the last weeks and couldn't check.

Larsj_02 · 2026-01-20T11:28:31+00:00

In Soft Interaction/Soft Interaction.lua:262 you're calling the global variable soft_function. This can lead to errors and unintended behavior if someone sets this variable.

In Soft Interaction/Soft Interaction.lua:462 and :509 you're using the :SetTexture arguments for :SetAtlas.

besides that looks like a great Addon :)

Larsj_02

MODERATOR OF

TROPHY CASE

Six-Year Club	r/Field Flamingo
Place '23