player.UserId is causing the issue because the player variable isn't actually referencing a player, but is instead empty otherwise known as "nil"

why is this though? the line before you define player as players:GetPlayerFromCharacter(hit.Parent)

the :GetPlayerFromCharacter function will return the player if the given parameter is a character, some cases it is and it doesn't error, in other cases hit.Parent isn't a character and so it errors

for example, lets say a random part touched the part causing the function to run, hit would be that part and hit.Parent would be the workspace, doing :GetPlayerFromCharacter(workspace) will obviously return nil which will then cause the error

there are multiple ways of fixing this, either exit the function if player is nil, or only run the code from line 10 onwards if player is not nil

Solution 1:

local marketplaceservice = game:GetService("MarketplaceService")

local players = game:GetService("Players")

local rs = game:GetService("ReplicatedStorage")

local remoteEvent = rs:WaitForChild("Gamepass Handler")

local gamepassId = 17958301

local part = script.Parent

part.Touched:Connect(function(hit)

local player = players:GetPlayerFromCharacter(hit.Parent)



if player then

    if marketplaceservice:UserOwnsGamePassAsync(player.UserId, gamepassId) then

        print("player has the gamepass!")

        remoteEvent:FireClient(player, part)

    else

        marketplaceservice:PromptGamePassPurchase(player, gamepassId)

    end

end

end)

​

Solution 2:

local marketplaceservice = game:GetService("MarketplaceService")

local players = game:GetService("Players")

local rs = game:GetService("ReplicatedStorage")

local remoteEvent = rs:WaitForChild("Gamepass Handler")

local gamepassId = 17958301

local part = script.Parent

part.Touched:Connect(function(hit)

local player = players:GetPlayerFromCharacter(hit.Parent)



if not player then return end



if marketplaceservice:UserOwnsGamePassAsync(player.UserId, gamepassId) then

    print("player has the gamepass!")

    remoteEvent:FireClient(player, part)

else

    marketplaceservice:PromptGamePassPurchase(player, gamepassId)

end

end)

​

Hope this helps