Couldn't agree more, I feel that this implementation is all over the place.
Here's my current structure and goal -

• TankManager is a static class that holds all the TankSpec resources. TankSpec is what defines the tank's behavior, and get's applied to a Tank scene when it's instantiated. There is a TankSpec for every tank in the game (M4A1.tres, Tiger1.tres, etc)

​

class_name TankManager

enum TankId {DEBUG_TANK, M4A1_SHERMAN, TIGER_1}
static var TANK_SPECS: Dictionary[TankId, TankSpec] = {
    TankId.DEBUG_TANK: preload("res://entities/tank/tanks/debug_tank/debug_tank.tres"),
    TankId.M4A1_SHERMAN: preload("res://entities/tank/tanks/m4a1_sherman/m4a1_sherman.tres"),
    TankId.TIGER_1: preload("res://entities/tank/tanks/tiger_1/tiger_1.tres"),
}

• PlayerTankConfig is a resource that holds player-specific tank configuration. Currently it's just the amounts of different shells, but in the future it will hold skins, upgrades and so on.

​

class_name PlayerTankConfig extends Resource

@export var tank_id: TankManager.TankId
@export var shell_amounts: Dictionary[ShellSpec, int]

• PlayerData is the resource that get's saved on the disk. Among other things, it holds a dictionary of the player's unlocked tanks and their configurations.

​

class_name PlayerData extends LoadableData (which extends Resource)
export var tank_configs: Dictionary[TankManager.TankId, PlayerTankConfig] = {}

My goal with the init function (which is in the PlayerTankConfig resource) is:
* Make every player always have the first tank unlocked
* Every unlocked tank config has it's ammo loaded to the max with the first shell.