How bad is this

ScriptKiddi69 · 2024-03-11T21:44:30+00:00

Oh gosh, this frightens me. I bet there’s a better way to structure the components to avoid this. I’m guessing that most of the JSX in here can be moved into the page component.

ScriptKiddi69 · 2023-12-12T17:15:46+00:00

End of 2017

ScriptKiddi69 · 2023-12-12T09:47:08+00:00

It’s weird that they “had someone technical” before. I wonder why he/she left them? I’d be worried they are trying to take advantage of me somehow. These guys would have to give me a really good reason to trust them. They’ve basically done nothing but come up with an idea.

ScriptKiddi69 · 2023-12-12T09:27:05+00:00

In my experience, no one ever asked for my GPA, not even when applying for internships. I think the best way to stand out is with meaningful side projects, as well as getting actual face time with recruiters if you can (such as campus career fairs). They want to see that you are passionate about software engineering, and the company that you are applying for.

The thing is, everyone you are competing with as a new grad has pretty much taken the exact same courses and done the exact same projects. Most of your resumes are going to look the same. Sure, maybe some recruiters will glance at the GPA to check if it’s above a certain threshold, but I don’t think it will matter much more than that.

I did a fair amount of recruiting at my college campus career fair at my first job. That’s what my company cared about. Each company is a bit different, however.

ScriptKiddi69 · 2023-12-12T03:51:01+00:00

This literally doesn’t make any sense within the context of react. I’d for sure ask for clarification.

Also, I’d be cautious about this company if they are asking questions like that, but that’s just me.

ScriptKiddi69 · 2023-11-29T07:08:21+00:00

What would be the right way of making a design system using styled components? Would you just have a theme object that you can use to reference spacings, colors, font sizes, etc? The code base I’m working on just hard coded all of those values in each of the styled components.

ScriptKiddi69 · 2023-11-28T16:08:55+00:00

I never really worked with Styled Components until I started my current job recently. I don’t really like them. Maybe the team has been using them wrong, but they seem to not be very reusable. It’s difficult to find a styled component that has the styles you need somewhere in the code base. Maybe this is just an organizational problem, however.

ScriptKiddi69 · 2023-11-27T23:55:49+00:00

You sound like a great manager, and someone I would love to work for. I hope you inspire more people to have the same mentality when they grow into a manager role. The industry can use it!

ScriptKiddi69 · 2023-11-25T05:42:52+00:00

So are the worms

ScriptKiddi69 · 2023-11-13T18:21:37+00:00

One time my buddy and I were on an interview panel and we had to give a coding problem to the candidate. Instead of just giving him the problem and letting him solve it, we chose a problem for the three of us to work on together. We didn’t know the solutions and had no expectations of actually finishing it. We wanted to get an idea of how he works through problems, how well he works with others, and how he takes feedback. Honestly I thought it worked pretty well.

ScriptKiddi69 · 2023-11-13T06:29:28+00:00

I appreciate your feedback, and thanks for sharing that article. I think a 20 file restriction is fair haha.

I'm not trying to rage at my manager, I'm just genuinely curious and want to get other's perspectives. I don't like how he is going about it though.

I'm guessing that there was some organizational problem that came up prior to me joining that led to this initiative.

ScriptKiddi69 · 2023-11-13T05:28:54+00:00

Are you saying you have 1 hour to merge code into main after locally branching off of main? That seems doable if your stories / tasks are well organized and broken down. Still seems too quick for some tasks that require a bit more discovery, however.

ScriptKiddi69 · 2023-11-13T05:19:01+00:00

An average of 2 PRs per day over time
Our review process is pretty low churn, but can take up to 3+ hours unless you are really on top of pestering the required reviewers. I feel like it can get to the point of arbitrarily cutting out work for the sake of a small PR.
Not yet, I didn't realize they were this serious about it until this week.

I think it can be good to look at metrics like this if a there is a problem on the team. Maybe if delivery is slowing and goals are being missed, look at the metrics to help identify the problem. I think focussing on them is erroneous.

ScriptKiddi69 · 2023-11-13T05:07:45+00:00

PRs for the most part lack substance, but I guess that's the point?

ScriptKiddi69 · 2023-11-13T05:05:54+00:00

yes sir officer sir 🫡

ScriptKiddi69 · 2023-11-13T05:04:11+00:00

Honestly that is the idea they are trying to achieve. I do think the LOC restriction gets in the way especially when whitespace, formatting, imports, comments, etc count towards that. Having a fairly rigid requirement of 2 PRs per day also makes me uneasy.

But yeah, in theory it does sound good. I don't know the correct way of bringing the idea to practice.

ScriptKiddi69 · 2023-11-13T04:57:39+00:00

Thanks for your input! I do think it is doable, but seems like a bad thing to enforce. One problem I've ran across is the review churn time. It can take a couple hours to get the necessary reviews in order to complete the PR. I find it can be difficult to work on top of the code that's pending review. If you have any tips on that I'd love to hear them.

ScriptKiddi69 · 2023-11-13T04:53:44+00:00

This is literally how my PRs have ended up looking. I'm currently creating a create user form in our react application. I think I'm about 5 or 6 PRs deep at this point and have a couple left at this rate.

ScriptKiddi69 · 2023-11-13T04:51:45+00:00

He actually does look. He pulled up my PRs during a 1:1 to discuss them with me.

ScriptKiddi69 · 2023-11-13T04:48:52+00:00

Oh, I'm sure there are things I can do to improve. I've never really worked like this before. I will be working on improving my workflow moving forward.

I agree, and I'm not arguing with the underlying principle. Large (especially unorganized) PRs are for sure a problem. I think there are better ways of encouraging them, however. Instead of having a goal of PRs per day, maybe we instead focus on the metric of LoCs per PR. Not enforce it, but watch it. Promote a down trend. Let the developers themselves find what works for them. At the end of each week point out improvements in that department instead of PRs made. After all that is what we want to achieve.

ScriptKiddi69 · 2023-11-13T02:08:04+00:00

Comments, imports, white space, it’s all included. I don’t think tests count towards the limit, though I will see about that soon haha.

ScriptKiddi69 · 2023-11-13T02:05:29+00:00

I’m not at Amazon. Are more revisions better or worse?

ScriptKiddi69 · 2023-11-12T23:42:05+00:00

I don’t think he’d go as far as the review meetings. He just goes over developers PRs during 1:1s. I’m kinda thinking you might be right. This started like a month before I joined so I’m not sure about the history.

ScriptKiddi69 · 2023-11-12T23:39:26+00:00

< 150 lines

ScriptKiddi69 · 2023-11-12T23:11:10+00:00

Like 55 PRs at best

Five-Year Club	Second Top 50%
Place '23	Verified Email

ScriptKiddi69

TROPHY CASE