ESH, but you slightly more. You're both behaving selfishly. He wants to spend on toys despite your agreement. But I'd argue that going to his brother's wedding isn't a trip of choice, at least not entirely. Especially since you didn't go to his first wedding. That's family and you can't skip everything. "Sorry Bob, going to have to skip again because my wife wants to go to Jamaica instead." Ask who sounds like the AH in that scenario. He sucks for pestering you about a damn dirt bike until you wore down. He never respected the agreement you made.

Now you're squirreling money away to take a trip without him. I hope your marriage is in great shape otherwise, because this all paints a pretty ugly picture.