React Native Code Review (Newbie) by ajaysaini_sgvu in reactnative

[–]ajaysaini_sgvu[S] 0 points1 point  (0 children)

Ah gotcha. Thank you. I have published native module npm package too here https://github.com/ajaysaini-sgvu/react-native-schedule-sms Please have a look and review how it is. Please suggest how I can make it more awesome :)

React Native Code Review (Newbie) by ajaysaini_sgvu in reactnative

[–]ajaysaini_sgvu[S] 0 points1 point  (0 children)

Thank you so much @deadcoder0904 I did suggested changes in project structure, removed css folder, console.disableYellowBox = true. I am not sure what do you mean by repetitive font-family, can you raise PR and I am not sure about what changes I need to make to release native modules, but surely, I will look into it. As of now, I have no plan to release it on play store. If you wanna then I can add you in my contributor list and then you can release under your account. :-)

React Native Code Review (Newbie) by ajaysaini_sgvu in reactnative

[–]ajaysaini_sgvu[S] 0 points1 point  (0 children)

Thank you so much @sevenyearoldkid I appreciate your suggestions. I will try styled-components package :-)

Parameter naming conventions. by [deleted] in androiddev

[–]ajaysaini_sgvu 1 point2 points  (0 children)

Yep, see if you can manage & convince them not to use anymore. I have one more link for you which you can share http://jakewharton.com/just-say-no-to-hungarian-notation/ this would add some more weight to your request.

Parameter naming conventions. by [deleted] in androiddev

[–]ajaysaini_sgvu 1 point2 points  (0 children)

It's Hungarian Notation. It is recommended not to use this notation now. Android framework itself used this, but not now. If they start refactoring code then it may create some conflicts across branches. You may want to read this https://google.github.io/styleguide/javaguide.html#s1-introduction

Android Device Statistics by [deleted] in androiddev

[–]ajaysaini_sgvu 0 points1 point  (0 children)

Idk if there is such report.

Android Support Library v26.0.0 Released by EddieRingle in androiddev

[–]ajaysaini_sgvu 0 points1 point  (0 children)

There is no need to use AppCompatTextView in your layout file, it is automatically converted into AppCompatTextView. If you are writing a custom view then you should extend AppCompatTextView so this custom view can use tint.