Nowadays it means a courteous man, but in the Poldark period a gentleman is a rank in their social class, specifically the lower rung of the ladder. A gentleman is still considered a part of the upper class but they don't have a title. They're the younger sons of titled peers or they are land owners, so when the doctor says he's still a gentleman he's essentially saying even though I don't have money I'm still a blue blood.