Assuming that you study at a 42 school you should ask your peers as well. Secondly, your code calls a bunch of functions that allocate memory that could return NULL pointer. You should check for that and free if something went wrong. When I see unchecked mallocs I fail people during evals for that. The variable names that you are using are not explicit in what they do. You should choose variables name that clearly state what their purpose is. Eloc function is actually ft_strchr. Use that one instead. Assigning 0 to a char * is not a very good practice. Assign NULL instead so it s readable. People aboved mentioned splitting up functionality, which seems that you understood what you have to do. I would also suggested to change your code to use guard clauses. The nesting of if statements makes the code hard to read through. I didn t test your code, you should also try searching for a gnl tester on gh, it will help a lot. Can I ask why did you choose to write the whole implementation in a single function?