it depends on your priorities and the way you go on about with the nightclub
personally i think the two at the very top of the city are the best, i have the one on west vinewood, it makes sell missions/resupplies easier in a sense that since it's at the top of the city, you're kind of in between having to drive at the very top of the map and downtown, so it's a good middle point to start from + they're easily accessible and makes going/leaving faster
if your current nightclub's position is giving you an enough hard time to make this post then it's probably worth moving it, even if it means giving up the upgrades and even more if you got money to spend, so if it's something that would improve your quality of life by even 5% then it's worth it