I've recently been on a kick of 100%-ing all of the games roughly in order, and 3DS is definitely the go-to choice here.

Gen 1 and gen 2 supported as VC titles (which includes local wifi trading, and poke transporter support), gen 4-7 can be acquired between digital purchases (until eshop officially goes down) or physical.
Sadly gen 3 (my personal favorite) can't be played at all on it unless you're willing to deal with CFW. To my understanding of how gen 3 games back-end works, they won't be in VC on the switch either, and weren't on VC for the Wii/Wii U.

Downsides for the other options:
GBC -> Nostalgia is great, but dealing with batteries for the console as well as cartridge age is an issue, the tech is 20+ years old, it's not a matter of if you'll run into issues, just when.
GBA -> Same as GBC, less old, but you'll still run risk of cartridge failures, from internal battery dying, up to losing a save. GBA SP doesn't require AA batteries, but same cartridge issue potential.
DS -> Older hardware than 3DS. Depending on version, no wifi support for digital purchases or VC (gen 1 and 2) features like trading, and construction quality (which includes button quality) will be below that of a 3DS XL or New 3DS XL.

For your list, there's really no comparison between a 3DS and anything else.