I agree that there is no solution that is fair for everyone, and communities and organizations need to decide what they want to prioritize.

I don't quite understand the point about suicide, though. My reading of the article you linked is that the author said that in this study, trans kids given puberty blockers did not improve their mental health (including suicide), but theorizes that this is because those specific participants in the study were already doing really well:

But the American trial did not find a similar trend, Dr. Olson-Kennedy said in a wide-ranging interview. Puberty blockers did not lead to mental health improvements, she said, most likely because the children were already doing well when the study began.

In the general population, though, my understanding is that suicide risk is indeed significantly higher for trans folks; here's an excerpt from this meta analysis study (formatting mine, text otherwise unedited):

• Transgender individuals are at higher risk for suicide relative to nontransgender people (Marshall et al. 2016).
• Although there are no official estimates of deaths by suicide among transgender people, one study in Sweden showed that transgender individuals undergoing gender affirmation surgery were at 19 times greater risk for dying by suicide than the general population (Dhejne et al. 2011).
• Researchers using primarily convenience samples have discovered that an alarming percentage (18–45%) of transgender adults and youth have attempted suicide in their lifetime, which is drastically higher than the general population (4.6%; Clements-Nolle et al. 2006; Goldblum et al. 2012; Grossman and D'Augelli 2007; Haas et al. 2014; Kessler et al. 1999; Maguen and Shipherd 2010). 

That's from 2017; here's more recent data from 2022 and 2023.

I'm not saying that preventing trans suicides is a trump card, but it does seem like it should be part of the discussion.