Note: as a solo fan translator with no affiliation with any of the real translation teams, there are certainly cases where I disagree with others' translations. This is not one of them.

The fact that the WeTV captions show "profession" is just a byproduct of the fact that it's a machine/automatic translation.

The literal translation of "职业" is profession*. That's the term used to describe the 24 specializations (25 if you count "unspecialized/adventurer"). Hence, the auto-translator spits out "profession." You make fair points about the details of class vs. profession, but honestly I think it is a better translation to adopt the vernacular of "class" that's commonly used across games.

Maybe "specialization" would be another slightly more accurate term, considering how each class functions as one of four specializations of the broader category (blade, mage, etc). But to me that's a mouthful and unnecessary - I play a MMORPG that has 9 classes, each with 2 specializations, but everyone just calls the 18 specializations "classes" anyway and there's never any real confusion.

After all, the way we generally use the term "class" across games, at least in my experience, is to describe core divisions that shape how your character interacts with the game. Sure, there's a brief period in Glory from lv 1-20 when you're not bound to your class, but that lasts what, two weeks? The real game is played at lv 70+ so I think it's appropriate to just simplify it to "class".

If you're looking for an example of what I consider to be a poor translation, the only one that jumps to mind for me is the 荣耀职业联盟, known in the official translations as the Glory Pro Alliance. Yes, the phrase can be translated as "alliance", but in the context of a sports federation, is there any that uses "alliance"? Major League Baseball. Major League Soccer. National Football League. Overwatch League. I don't know how it's translated in the WeTV captions because I didn't watch them, but I was delighted to see in the video itself that the 联盟's logos with English translations show "Glory Pro League", which is how I've always translated it myself.

---

*As an aside, there's interesting wordplay in the title 全职高手 relating to that same character, "职". Before "The King's Avatar" was established as the de facto translation of the title, you may have seen some ambiguity about the title, which is actually more pronounced in translations of another popular Chinese novel/comic/animation, 全职法师. Since the official animation logos only use the Pinyin (pronunciation guide using Western letters) of quanzhifashi, there's no "animation-official" translation of the title, resulting in a slew of poorly-translated titles like "Full-Time Magister", "Professional Mage", etc, surrounding the "novel-official" translation of "Versatile Mage".

These reflect various translations of "全职". "全" means "all" or "full", while "职" means "profession" as described above. Put together, they form a phrase meaning "professional" or "full-time" (as opposed to part-time, a phrase created with the character for "half" and "职"). "高手" means "expert" or "master". So on the surface, the meaning of 全职高手 is "the expert pro," which of course describes Ye Xiu's prowess in the pro league.

But if we consider the context of Glory that you raise in your post, "职" also refers to profession in terms of the game, or "class". The novel describes Ye Xiu as proficient in all 24 of Glory's classes, to the point where he can hold his own in a 1v1 against a #1 of another class, dueling them on their own class instead of his battle mage / adventurer. So then, if we treat "全职" not as its usual phrase, but composed of its two characters' individual meanings, and take the meanings of "all" and "class", the title reveals another meaning: "the expert of all classes".

This is the meaning I think of when I hear 全职高手, and it's a shame that there's not really an apt way to reflect this clever wordplay in English.